Add GitHub Action workflow to run lua tests/test_py.lua#103
Conversation
cclauss
changed the title
cclauss
changed the title
cclauss
force-pushed
the
tests_test_py.lua
branch
13 times, most recently
from
4a1c7c2 to
b1baf66
Compare
|
@bastibe @gward @leso-kn @shmuz @skorokithakis Your reviews, please? |
There was a problem hiding this comment.
Hey there :)
Sorry for the delay, the heatwave in my country made it virtually impossible to review things.
Thanks for the update!
I would generally prefer if we continue the work in existing pull-requests (in order to keep the comment history), I have added a note that this is a continuation of #96 in the PR description. But your changes look fine, I wrote some minor comments.
| - run: luarocks lint lunatic-python-scm-0.rockspec | ||
| - run: luarocks lint rockspecs/lunatic-python-1.0-1.rockspec | ||
| - run: luarocks --local make | ||
| - run: luarocks show lunatic-python |
There was a problem hiding this comment.
Very well done! Linting the rockspecs and showing the package is actually a very cool idea here :)
| # TODO: Linux Lua5.4 only: lua5.4: python.so: undefined symbol: lua_insert | ||
| # TODO: Linux Lua5.5 only: lua5.5: python.so: undefined symbol: luaL_openlibs | ||
| - if: matrix.lua-version == '5.1' || matrix.lua-version == '5.3' | ||
| run: lua${{ matrix.lua-version }} tests/test_py.lua |
There was a problem hiding this comment.
Where did python -m doctest tests/test_lua.py from #96 go?
We should test both bridges (Lua in Python / Python in Lua)!
There was a problem hiding this comment.
cclauss
force-pushed
the
tests_test_py.lua
branch
from
b1baf66 to
2f6a631
Compare
2 participants
Note
This pull-request is a continuation of #96
Add a GitHub Action to run
lua tests/test_py.luaso we can focus on fixes for:python.so: undefined symbol:luaL_loadbuffer#98python.so: undefined symbol:lua_insert#99python.so: undefined symbol:luaL_openlibs#100All 10 GHA runs pass on both
ubuntu-26.04andubuntu-26.04-arm.I believe that this is the best GitHub Actions PR to review and merge. It runs a test that passes and can provide feedback for three issues that can then be fixed and closed. Once this is merged, we will have Lua builds with continuous integration basic guardrails in place, and any other GHA PRs can be rebased.