Use Starlark tuples for C++ module-map headers - #809
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
marked this pull request as ready for review
July 31, 2026 18:24
Collaborator
|
as with #812 , waiting until we have spare time to run benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store private module-map callback sequences as immutable Starlark tuples instead of calling
_cc_internal.freeze. The_ModuleMapInfocallback preserves header ordering, tree-artifact expansion, andArgs.map_eachbehavior while eliminating the module's Java-backedcc_internaldependency.Add a configured-target regression test verifying that generated header directories are included in the
CppModuleMapaction.Validation:
buildifier -mode=checkand seven passing C++ module-analysis tests, including the new generated-tree-header test.