Starlarkify Objective-C option expansion and tokenization - #815
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
marked this pull request as ready for review
July 31, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
_cc_internal.expand_and_tokenizewith the existing Starlark make-variable expansion, location expansion, and Bourne-shell tokenization implementations. Move those existing helpers intocc_helper_internal.bzlso both C++ and Objective-C callers use the same implementation without introducing a load cycle; preserve the exportedcc_common.objc_expand_and_tokenizeAPI and its private-call checks.Add Objective-C analysis coverage for quoted values, escaped spaces, make variables, escaped dollars, and source, non-ARC source, header, and data locations.
Validation:
buildifier -mode=checkand 31 passing Objective-C and C++ configured-target analysis tests, including both new Objective-C regression tests.