Label the perf image per variant - #1013
Open
epompeii wants to merge 1 commit into
Open
Conversation
Contributor
|
| Project | Bencher |
| Branch | u/ep/parameters-api/perf-img |
| Testbed | intel-v1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (碌s) (Result 螖%) | Upper Boundary microseconds (碌s) (Limit %) |
|---|---|---|---|
| Adapter::Json | 馃搱 view plot 馃毞 view threshold | 5.22 碌s(+10.09%)Baseline: 4.74 碌s | 5.47 碌s (95.45%) |
| Adapter::Magic (JSON) | 馃搱 view plot 馃毞 view threshold | 5.02 碌s(+9.10%)Baseline: 4.60 碌s | 5.25 碌s (95.57%) |
| Adapter::Magic (Rust) | 馃搱 view plot 馃毞 view threshold | 26.98 碌s(+3.75%)Baseline: 26.01 碌s | 27.93 碌s (96.61%) |
| Adapter::Rust | 馃搱 view plot 馃毞 view threshold | 4.62 碌s(+26.45%)Baseline: 3.65 碌s | 5.11 碌s (90.40%) |
| Adapter::RustBench | 馃搱 view plot 馃毞 view threshold | 4.64 碌s(+27.21%)Baseline: 3.65 碌s | 5.09 碌s (91.09%) |
epompeii
force-pushed
the
u/ep/parameters-api/perf-img
branch
from
August 27, 2026 03:46
cc7af31 to
d07c844
Compare
epompeii
force-pushed
the
u/ep/parameters-api/perf-img
branch
from
August 27, 2026 05:11
d07c844 to
55c0f84
Compare
epompeii
force-pushed
the
u/ep/parameters-api/perf-img
branch
from
August 30, 2026 17:08
55c0f84 to
a24d29e
Compare
epompeii
marked this pull request as ready for review
August 30, 2026 17:38
The image endpoint takes `parameters`, the same comma separated list of URL
encoded parameter sets the query endpoint takes, spelled the same way and read by
the same code path. The image query struct mirrors the query struct field for
field, doc comment included, so the image is the plot of the query it mirrors.
A line plots one variant, so the key names the variant when the benchmark name no
longer says which line is which. A benchmark whose every line in the image plots
the empty parameter set keeps the bare benchmark name it has always had. One non
empty set among a benchmark's lines names them all, the empty set among them
included, which reads `{}`. The set is spelled in its canonical form and follows
the benchmark name on the same row, so the wrapping the key text already does for
a long benchmark name loses the tail of the set spelling first and the name never.
A project that never reported a parameter set is drawn from the inputs it was
always drawn from: every line of every such benchmark is labeled exactly as
before, which the fixtures pin, and nothing else on the draw path moved.
A point whose measure named no `value` has no point estimate to place on the axis,
so the plot leaves it out of the line. That already held; a fixture now pins it.
epompeii
force-pushed
the
u/ep/parameters-api/perf-img
branch
from
August 30, 2026 18:40
a24d29e to
c7eb251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perf image catches up with the perf query.
The parameter
The image endpoint takes
parameters, the same comma separated list of URL encoded parameter sets the query endpoint takes, spelled the same way and read by the same code path. The image query struct mirrors the query struct field for field, doc comment included, so the image is the plot of the query it mirrors. An endpoint test pins that: the image of a filtered query is byte for byte the plot of that query's own response.The label rules
A line plots one variant, so the key names the variant when the benchmark name no longer says which line is which.
{}.What older projects see
A project that never reported a parameter set is drawn from the inputs it was always drawn from. Every line of every such benchmark is labeled exactly as before, which the existing fixtures pin line by line, and nothing else on the draw path moved.
Points with no value
A point whose measure named no
valuehas no point estimate to place on the axis, so the plot leaves it out of the line rather than drawing it at zero. That already held; a fixture now pins it.