Conversation
epompeii
marked this pull request as ready for review
September 26, 2026 01:02
Contributor
|
| Project | Bencher |
| Branch | u/ep/callback/metrics |
| Testbed | intel-v1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| Adapter::Json | 📈 view plot 🚷 view threshold | 5.17 µs(+4.95%)Baseline: 4.92 µs | 6.00 µs (86.20%) |
| Adapter::Magic (JSON) | 📈 view plot 🚷 view threshold | 4.97 µs(+4.34%)Baseline: 4.76 µs | 5.68 µs (87.42%) |
| Adapter::Magic (Rust) | 📈 view plot 🚷 view threshold | 27.63 µs(+3.58%)Baseline: 26.67 µs | 30.32 µs (91.11%) |
| Adapter::Rust | 📈 view plot 🚷 view threshold | 4.68 µs(+15.48%)Baseline: 4.06 µs | 6.35 µs (73.70%) |
| Adapter::RustBench | 📈 view plot 🚷 view threshold | 4.66 µs(+15.06%)Baseline: 4.05 µs | 6.33 µs (73.61%) |
epompeii
added this pull request to stack #1054
September 26, 2026 02:44
epompeii
marked this pull request as draft
September 26, 2026 03:30
epompeii
marked this pull request as ready for review
September 26, 2026 04:19
epompeii
marked this pull request as draft
September 26, 2026 05:18
epompeii
force-pushed
the
u/ep/callback/metrics
branch
from
September 26, 2026 14:13
8251882 to
9312c58
Compare
epompeii
marked this pull request as ready for review
September 26, 2026 14:49
epompeii
marked this pull request as draft
September 26, 2026 17:40
epompeii
force-pushed
the
u/ep/callback/metrics
branch
2 times, most recently
from
September 26, 2026 20:21
f30c36d to
436cb6f
Compare
epompeii
force-pushed
the
u/ep/callback/metrics
branch
2 times, most recently
from
September 27, 2026 01:40
ef1a727 to
a1ed80b
Compare
epompeii
force-pushed
the
u/ep/callback/metrics
branch
from
September 27, 2026 02:45
a1ed80b to
a932a18
Compare
Every delivery attempt is counted by its class: a status class, a timeout, a connection error, or a block with its reason. Every callback that settles is recorded by its outcome and failure reason in histograms of its latency from the start of its delivery and of the attempts it made over its life. A gauge counts the callbacks waiting to be delivered, read from the database at each export on a read connection only if one is free, so a busy pool skips a point instead of stalling the export. No attribute carries a URL, a header, an address, or any other value from the request.
epompeii
force-pushed
the
u/ep/callback/metrics
branch
from
September 27, 2026 03:03
a932a18 to
87646ad
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callbacks get OpenTelemetry metrics.
callback.attemptcounts each attempt by its class: a status class, a timeout, a connection error, or a block with its reason.callback.finish.durationandcallback.finish.attemptsrecord each callback that settles, by its outcome and failure reason: its latency from the start of its delivery, and the attempts it made over its life. Only a settle that committed is recorded, and both have bucket boundaries sized for their values.callback.pendingis an observable gauge of the callbacks waiting to be delivered, read from the database at each export on a read connection only if one is free, so a busy pool skips a point instead of stalling the export.Every attribute comes from a fixed enum, so no attribute carries a URL, a header, an address, or any other value from the request.
Needed for #1046