Skip to content

Improve bit Boilerplate Brouter integration (#12704)#12705

Merged
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:release
Jul 19, 2026
Merged

Improve bit Boilerplate Brouter integration (#12704)#12705
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:release

Conversation

@yasmoradi

@yasmoradi yasmoradi commented Jul 19, 2026

Copy link
Copy Markdown
Member

closes #12704

Summary by CodeRabbit

  • Bug Fixes

    • Improved tenant isolation and resolution consistency across requests.
    • Background operations now require explicit tenant context instead of silently using a fallback.
    • Improved initial route-state publishing for supported application templates.
    • Updated Windows deployment configuration for application settings and update files.
  • Documentation

    • Clarified tenant resolution order, pooled database context requirements, and background-job guidance.
  • Chores

    • CI test failures now stop jobs immediately, providing more reliable build validation.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 82269774-7092-439d-a14b-b2008dae5eed

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb7bb0 and 6a1cf2b.

📒 Files selected for processing (11)
  • .github/workflows/admin-sample.cd.yml
  • .github/workflows/bit.full.ci.yml
  • .github/workflows/sales-module-demo.cd.yml
  • .github/workflows/todo-sample.cd.yml
  • src/Templates/Boilerplate/Bit.Boilerplate/.docs/07- ASP.NET Core Identity - Authentication & Authorization.md
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/AppRouteDataPublisher.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Products/ProductsPage.razor.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Features/Identity/Services/TenantProvider.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Infrastructure/Data/AppDbContext.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Program.Services.cs
💤 Files with no reviewable changes (4)
  • .github/workflows/admin-sample.cd.yml
  • .github/workflows/sales-module-demo.cd.yml
  • .github/workflows/todo-sample.cd.yml
  • .github/workflows/bit.full.ci.yml

Walkthrough

The change updates boilerplate tenant resolution and pooled database wiring, adds conditional route-data initialization, adjusts template build settings, changes Windows deployment substitutions, and makes database test failures fail CI jobs directly.

Changes

Tenant runtime and database wiring

Layer / File(s) Summary
Tenant resolution behavior
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/.../TenantProvider.cs, src/Templates/Boilerplate/Bit.Boilerplate/.docs/...Identity...md
TenantProvider removes explicit overrides, throws without HttpContext, and documents the updated claim, host, fallback, and background-job behavior.
Pooled context and provider wiring
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/.../AppDbContext.cs, .../Program.Services.cs
AppDbContext lazily resolves the singleton TenantProvider; pooled contexts use a shared PostgreSQL data source with vector and dynamic JSON support.

Template client integration

Layer / File(s) Summary
Conditional route-data publishing
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/.../AppRouteDataPublisher.cs, .../ProductsPage.razor.cs, .../Directory.Build.props
Route data is published during conditional initialization, and template directives plus warning settings are updated.

CI/CD workflow updates

Layer / File(s) Summary
Windows hybrid appsettings substitution
.github/workflows/*-sample.cd.yml, .github/workflows/sales-module-demo.cd.yml
Windows hybrid substitutions remove OTLP settings and add Sentry, reCAPTCHA, and Windows update values.
Database test failure propagation
.github/workflows/bit.full.ci.yml
PostgreSQL and SQL Server test steps now fail jobs directly, replacing deferred aggregate outcome checks.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Request as HttpContext
  participant Provider as TenantProvider
  participant Context as AppDbContext
  Request->>Provider: claims and host information
  Provider->>Provider: resolve tenant or throw without HttpContext
  Context->>Provider: lazily read CurrentTenantId
  Provider-->>Context: resolved tenant id
Loading

Suggested reviewers: msynk

Poem

A bunny hops through tenant streams,
With pooled contexts and route-data dreams.
CI flags failures, settings bloom,
Windows builds find their proper room.
“Hop-hop!” says the rabbit, “the templates align!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change and matches the PR’s Boilerplate Brouter integration improvements.
Linked Issues check ✅ Passed The changes align with #12704 by improving Boilerplate Brouter integration across server, client, docs, and workflows.
Out of Scope Changes check ✅ Passed No obvious unrelated code changes stand out; the edits all appear tied to the Boilerplate Brouter integration work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yasmoradi
yasmoradi merged commit d0b88d5 into bitfoundation:develop Jul 19, 2026
42 of 50 checks passed
@yasmoradi
yasmoradi deleted the release branch July 19, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit Boilerplate brouter integration needs improvements

1 participant