feat(voice): control berd-call from the menu bar - #345
johnmatthewtennant wants to merge 1 commit into
Conversation
|
🤖 Review dispositions at 5c5be31 (fixed in fb1084e):
|
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
APPROVE: the completed static review of the exact three-dot comparison found no publishable findings or duplicates. The supplied GitHub checks completed successfully.
Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Pending checks: 1 check(s) are not complete.
This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.
The base branch was changed.
Adds a macOS menu bar item to standalone berd-call calls for status, mute, rate, voice, and ending the call. Signed-off-by: John Tennant <jtennant@block.xyz>
61192d9 to
55cab32
Compare
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
COMMENT: the exact three-dot comparison has one non-blocking concurrency finding in menu action handling. Supplied GitHub evidence is structurally valid; one frontend check is still in progress, while the other reported checks have passed. Required checks independently govern merge readiness.
Deterministic publication result: 0 blocking and 1 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Summary
Adds a macOS menu bar to
berd-call startwith the call controls VCCLI's menu bar offers.berd-call status, which a background thread refreshes every second so the main thread never waits on the control socket, and the icon switches to a crossed-out microphone while muted.berd-call settingsorberd-call stop, so the menu and the CLI never disagree about call state.--no-menu-barruns the call without it, for headless use.Reviewer-reproducible example
berd-call start --port 5343 --stream --voice Aaron --language en-US &A waveform icon appears in the menu bar. Choose Speech Rate → 0.5×, then Mute Microphone, then Mute Input During TTS. Afterward:
Reopening the menu shows "Speech Rate: 0.5×" and checkmarks beside both mute items. End Call stops the call and the process exits. With
berd-call start --no-menu-bar --port 5344 --voice Aaron --language en-US, the call runs and responds toberd-call status, but no menu-bar item appears.