Conversation
Signed-off-by: Zach Marley <zmarley@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onOpenLinkplumbing and labels them Open image in browser instead of presenting them as downloads.Linear: https://linear.app/squareup/issue/BOT-1930/view-images-and-galleries
Source-derived risk
Download imagefor relay proxy media and externalOpen image in browserintentionally remain distinct shared-policy cases.ChannelsPage.openLinkcan returnfalsefor ordinary HTTPS by design, so this PR does not claim verified native system-browser external opener behavior. The_blankfallback attributes are established; real browser/package navigation remains pending.Design notes
~/goose artifacts/buzz-design-system-pack/AGENTS.md,DESIGN.md, andcomponents/registry.json;IconButtonis listed with statusproposed.IconButtonand the Phosphor gateway export for the existingArrowSquareOutIcon.tests/fixtures/messages.tsxchanged only as code fixture data.Tests
bin/pnpm typecheckbin/pnpm exec biome check --error-on-warnings src/bundled/channels/ChannelsPage.tsx src/features/messages/FileAttachment.tsx src/features/messages/ImageReviewStage.tsx src/features/messages/MediaReviewViewer.tsx src/features/messages/attachment-source.ts src/features/messages/MediaReviewViewer.test.tsx src/features/messages/icon-labels.test.tsx tests/fixtures/messages.tsxbin/pnpm exec vitest run src/features/messages/MediaReviewViewer.test.tsx src/features/messages/icon-labels.test.tsx— 2 files, 10 testsbin/pnpm design:checkDeferred / not verified
just scanare deferred pending explicit approval.