Conversation
🔐 Codex Security Review
|
Signed-off-by: Asterracy <311249772+Asterracy@users.noreply.github.com>
Asterracy
force-pushed
the
i18n-zh-hans
branch
from
September 21, 2026 23:12
e6eae63 to
3343dee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zh-Hans).system/en/zh-Hanslanguage preference with immediate switching.LOCALIZATION.zh-Hans.md.Relationship to existing localization work
This PR is intentionally related to and overlaps the existing i18n work:
The existing PRs provide the relevant architectural context. This branch presents a complete
zh-Hansdesktop implementation for maintainer review. If maintainers prefer #5152 or another base, this PR can be split, rebased, or closed in favor of that direction.Verification
All checks below were rerun from a clean clone based on the current upstream
main:pnpm exec node src/i18n/catalogValidation.mjs— pass (catalog parity ok)pnpm typecheck— passpnpm check— pass; 2 warnings and 5 infos, no errorspnpm test— 6572 passed, 0 failed, 0 skippedpnpm build— pass; protected feature artifact matrix passedjust desktop-tauri-check— passThe locale catalog contains 4082 leaf keys in both English and Simplified Chinese, with no missing or empty Chinese values.
Scope and attribution
Review request
Please advise whether maintainers prefer this as one complete locale contribution or as a sequence of smaller infrastructure, catalog, and surface PRs.