Skip to content

fix(desktop): collapse mixed membership arrivals and departures into one timeline row - #7786

Open
pete-lucern wants to merge 1 commit into
block:mainfrom
pete-lucern:fix/desktop-collapse-membership-rows
Open

pete-lucern wants to merge 1 commit into
block:mainfrom
pete-lucern:fix/desktop-collapse-membership-rows

Conversation

@pete-lucern

Copy link
Copy Markdown

Problem

The desktop timeline split contiguous membership activity whenever an admin removal or member departure appeared, producing alternating single rows during bursts of channel membership changes.

Change

Contiguous member_joined, member_removed, and member_left events now collapse into one anchored timeline row when they stay within the existing adjacency window and do not cross a barrier. Mixed rows render deduplicated added and removed member name lists with the existing truncation behavior. Pure-arrival and self-join-then-leave summaries retain their existing copy.

Verification

  • Alternating 20-event burst: 20 rows before → 1 row after.
  • Two membership bursts separated by an ordinary message: 4 rows before → 2 rows after.
  • Events more than one hour apart: 2 rows before → 2 rows after.
  • Focused touched-file tests: 44 passed, 0 failed.
  • Full desktop test script: 6,497 passed, 15 failed; the 15 failures are unrelated existing agent, inbox, thread-reply, and project Git-view tests.
  • Biome check passes on all touched files.
  • Screenshots not required.

Closest existing PR: none found

…one timeline row

Signed-off-by: Pete Casella <pete@lucern.ai>
@pete-lucern
pete-lucern requested a review from a team as a code owner September 21, 2026 19:57
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 77729abfb692b25a0f4ec4a69add86af2e32c0dd...1d0b575f8d67fc3ed583ee94d1c854a6814d0006.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 1d0b575f8d67fc3ed583ee94d1c854a6814d0006 to authorize a new review.
Any previous review applies only to its recorded range.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant