feat(relay): allow channel admins to edit posts in their channel with edited_by provenance - #7788
Open
pete-lucern wants to merge 1 commit into
Open
pete-lucern wants to merge 1 commit into
pete-lucern wants to merge 1 commit into
Conversation
… edited_by provenance Signed-off-by: Pete Casella <pete@lucern.ai>
🔐 Codex Security Review
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Channel admins could delete and edit channel metadata, but kind
40003message edits were limited to the original author (or the existing agent-owner exception). Projected tile/status-board posts therefore could not be maintained by a designated channel administrator.Change
owner/adminmember of the target event's channel, to edit a message. The existing same-channel target check remains enforced; admins from another channel are rejected.edited_bytag naming the editor, leaving the original event author unchanged. The SDK, CLI, and desktop builders now add this provenance.40099system message with typemessage_edited_by_admin, actor, target event ID, and channel. Desktop renders it as “ edited a message”.Tests
cargo clippy -p buzz-relay --lib -- -D warnings: passed.cargo check -p buzz-cli: passed.cargo test -p buzz-relay --lib: 1063 passed, 7 failed, 122 ignored. The seven failures are unrelated environment-sensitive tests: six require a local Postgresbuzzrole, and one telemetry test depends on process-global tracing state.Closest existing PR:
None found for channel-admin message editing.
gh pr list -R block/buzz --search "edit admin"returned no directly relevant match; the closest-looking result was #5243, which concerns DM participant renaming rather than channel message authorization.