Conversation
added 3 commits
September 22, 2026 06:38
Signed-off-by: Bobby <fa3b487e7f5e37cdc997b0529186cacf1433136b69f4da3827c48c84e22b5744@nostr.invalid>
Signed-off-by: Bobby <fa3b487e7f5e37cdc997b0529186cacf1433136b69f4da3827c48c84e22b5744@nostr.invalid>
Signed-off-by: Bobby <fa3b487e7f5e37cdc997b0529186cacf1433136b69f4da3827c48c84e22b5744@nostr.invalid>
🔐 Codex Security Review
|
Signed-off-by: Bobby <fa3b487e7f5e37cdc997b0529186cacf1433136b69f4da3827c48c84e22b5744@nostr.invalid>
samrik246
marked this pull request as ready for review
September 22, 2026 22:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed ACP permission requests previously advanced through an automatically selected option. This PR holds both ACP read loops at the exact pending request until the authenticated owner selects an offered option. The Desktop card shows the action and target, and the response is bound to the channel, runtime generation, session, turn, typed request ID, action digest, and selected option. Duplicate, mismatched, expired, and replayed decisions fail closed.
When an ACP adapter sends
$/cancel_requestfor that pending permission request, the host now persistsCancelled, writes a JSON-RPCcancelledoutcome using the original typed ID, and only then clears its in-memory pending state. If the response write fails, the ledger recordsDeliveryUnknownand the owner card remains inert. Unmatched, late, wrong-typed, and cross-session cancellations cannot cancel another request. The cancelled response terminalizes an open Desktop card, while the durable ledger keeps a replayed or reconnected card inert.Native Guardian denial retry requires a compatible adapter and is reviewed separately; this PR does not publish or install that adapter.
Related issue
None found.
Validation
cargo test -p buzz-acp: 953 unit tests passed, 1 ignored; 9 lifecycle integration tests passed.CHECK_FILE_SIZES_BASE=4107b16e714407e166c596a97f91bf2f346bee86 just file-size-check: passed.just ci: passed locally on the unchanged candidate with the explicit file-size base, process-local Xcode 26.5 SDK, and external Cargo/TMPDIR staging.git diff 4107b16e714407e166c596a97f91bf2f346bee86 HEAD --check: passed; commit is DCO-signed.The source candidate is
6a51ecba9a10b9ecf837887a3d69d1bc94f9ba63. A side-by-side local app artifact was reviewed separately. Installed live acceptance remains pending; this draft PR does not claim deployment or a passing remote security review.