Add completed PropertyDescriptor type - #5284
Conversation
Test262 conformance changes
Fixed tests (2):Tested main commit: |
38fea6d to
40d9a5e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5284 +/- ##
===========================================
+ Coverage 47.24% 62.77% +15.52%
===========================================
Files 476 536 +60
Lines 46892 60498 +13606
===========================================
+ Hits 22154 37975 +15821
+ Misses 24738 22523 -2215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
40d9a5e to
1594d05
Compare
1594d05 to
c9edeab
Compare
jedel1043
left a comment
There was a problem hiding this comment.
Mostly looks great! I just have a suggestion to avoid introducing more panics in the engine.
e86e5c5 to
5e9220e
Compare
|
You might need to bump to v0.23 since removing |
81a97ad to
47d60cb
Compare
Refactors property descriptor handling by replacing the builder-style PropertyDescriptor with a more explicit
CompletePropertyDescriptorenum. This makes things clearer and more type-safe. The spec always stores complete property descriptors in objects.Since descriptors are always complete, this allows us to skip some checks and may allow the compiler to better optimize the code. Additionally this also reduces the memory usage for sparse generic arrays,
CompletePropertyDescriptoris 24 bytes vs.PropertyDescriptor40 bytes (64bit arch).