Skip to content

fix: resolve failing tests from iterator.zip - #5502

Merged
nekevss merged 4 commits into
boa-dev:mainfrom
jedel1043:fix-iterator-zip-bugs
Sep 1, 2026
Merged

fix: resolve failing tests from iterator.zip#5502
nekevss merged 4 commits into
boa-dev:mainfrom
jedel1043:fix-iterator-zip-bugs

Conversation

@jedel1043

Copy link
Copy Markdown
Member

This puts us in 100% conformance for Iterator.zip and Iterator.zipKeyed.

@jedel1043
jedel1043 requested a review from a team as a code owner August 31, 2026 08:07
@jedel1043 jedel1043 changed the title fix: resolve failing tests from iterator zip fix: resolve failing tests from iterator.zip Aug 31, 2026
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Aug 31, 2026
@github-actions github-actions Bot added this to the v0.23 milestone Aug 31, 2026
@github-actions github-actions Bot added the C-Builtins PRs and Issues related to builtins/intrinsics label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,578 53,578 0
Passed 51,435 51,408 -27
Ignored 1,622 1,666 +44
Failed 521 504 -17
Panics 0 0 0
Conformance 96.00% 95.95% -0.05%
Fixed tests (13):
test/built-ins/Iterator/zipKeyed/iterables-iteration-get-own-property-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zipKeyed/suspended-start-iterator-close-calls-next.js (previously Failed)
test/built-ins/Iterator/zipKeyed/iterables-iteration-get-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zipKeyed/suspended-start-iterator-close-calls-return.js (previously Failed)
test/built-ins/Iterator/zipKeyed/padding-iteration-get-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zipKeyed/iterables-iteration-get-iterator-flattenable-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zip/padding-iteration-iterator-close-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zip/suspended-start-iterator-close-calls-next.js (previously Failed)
test/built-ins/Iterator/zip/iterables-iteration-iterator-step-value-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zip/suspended-start-iterator-close-calls-return.js (previously Failed)
test/built-ins/Iterator/zip/padding-iteration-iterator-step-value-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zip/iterables-iteration-get-iterator-flattenable-abrupt-completion.js (previously Failed)
test/built-ins/Iterator/zip/padding-iteration-get-iterator-abrupt-completion.js (previously Failed)

Tested main commit: 10ef23505ecae734a4984d7839fec99a7ca8482c
Tested PR commit: a9bf5cf7518e5b2cdb68c0179c4e7f4d894b67ec
Compare commits: 10ef235...a9bf5cf

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.61905% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.36%. Comparing base (6ddc2b4) to head (a9bf5cf).
⚠️ Report is 1043 commits behind head on main.

Files with missing lines Patch % Lines
...ngine/src/builtins/iterable/iterator_helper/mod.rs 60.00% 18 Missing ⚠️
...gine/src/builtins/iterable/iterator_constructor.rs 16.66% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5502       +/-   ##
===========================================
+ Coverage   47.24%   62.36%   +15.11%     
===========================================
  Files         476      535       +59     
  Lines       46892    59884    +12992     
===========================================
+ Hits        22154    37344    +15190     
+ Misses      24738    22540     -2198     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the C-Tests Issues and PRs related to the tests. label Aug 31, 2026

@nekevss nekevss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss
nekevss added this pull request to the merge queue Sep 1, 2026
Merged via the queue into boa-dev:main with commit a32fae6 Sep 1, 2026
22 checks passed
@github-actions github-actions Bot removed the Waiting On Review Waiting on reviews from the maintainers label Sep 1, 2026
@jedel1043
jedel1043 deleted the fix-iterator-zip-bugs branch September 1, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants