Skip to content

feat(runtime): add delegated control and AI approval review - #21

Merged
boh5 merged 3 commits into
mainfrom
codex/multi-agent-control-plane
Aug 21, 2026
Merged

feat(runtime): add delegated control and AI approval review#21
boh5 merged 3 commits into
mainfrom
codex/multi-agent-control-plane

Conversation

@boh5

@boh5 boh5 commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • add durable delegated-session control with shared Agent Tree projection, steer/queue messaging, subtree cancellation, waiting, and resumption
  • add automatic Fast-profile review for unresolved ask permissions before HITL, with fail-closed fallback and Security settings control
  • update protocol, server, web UI, design-system artifacts, architecture contracts, integration coverage, and project documentation

Validation

  • git diff --check origin/main...HEAD
  • bun run typecheck
  • bun run test
  • bun run build

Review in cubic

boh5 added 2 commits August 20, 2026 22:46
Review unresolved permission requests with the configured Fast profile before creating HITL requests. Default the setting on, preserve fail-closed behavior, and expose the control in Security settings.
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 119 files, which is 19 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c312c7d-ec37-4977-984b-bc2b251a5d73

📥 Commits

Reviewing files that changed from the base of the PR and between f64ad76 and 0aa4611.

📒 Files selected for processing (119)
  • AGENTS.md
  • apps/server/src/routes/config.test.ts
  • apps/server/src/routes/sessions.test.ts
  • apps/server/src/routes/sessions.ts
  • apps/web/src/api/queries.ts
  • apps/web/src/api/types.ts
  • apps/web/src/components/features/ContextInspector.interaction.tsx
  • apps/web/src/components/features/SettingsDialog.interaction.tsx
  • apps/web/src/components/features/SettingsDialog.tsx
  • apps/web/src/components/features/SettingsSecurityPanel.tsx
  • apps/web/src/components/features/context-inspector/SessionAgentsInspector.test.tsx
  • apps/web/src/components/features/context-inspector/SessionAgentsInspector.tsx
  • apps/web/src/components/features/context-inspector/session-inspector-projection.ts
  • apps/web/src/components/features/orchestration-surface.test.ts
  • apps/web/src/components/features/settings-panels.tsx
  • apps/web/src/context/global-sse.test.tsx
  • apps/web/src/context/global-sse.tsx
  • apps/web/src/hooks/use-live-session-diff.ts
  • design-system/pages/settings.md
  • design-system/prototypes/app.js
  • design-system/prototypes/automations.html
  • design-system/prototypes/index.html
  • design-system/prototypes/session.html
  • design-system/prototypes/sessions.html
  • design-system/prototypes/settings.html
  • design-system/prototypes/styles.css
  • design-system/prototypes/todos.html
  • docs/goals/multi-agent-delegation-control-plane-hard-cut-plan-goal.md
  • docs/goals/multi-agent-delegation-control-plane-hard-cut-progress.md
  • docs/goals/permission-auto-review-plan-goal.md
  • docs/goals/permission-auto-review-progress.md
  • packages/agent-core/src/__arch__/shared-code-unification.test.ts
  • packages/agent-core/src/__arch__/tool-output-policy-matrix.test.ts
  • packages/agent-core/src/agent-tree/index.ts
  • packages/agent-core/src/agent-tree/projection.test.ts
  • packages/agent-core/src/agent-tree/projection.ts
  • packages/agent-core/src/agents/configured-agent.test.ts
  • packages/agent-core/src/agents/configured-agent.ts
  • packages/agent-core/src/agents/constants.ts
  • packages/agent-core/src/agents/definitions/analyst.ts
  • packages/agent-core/src/agents/definitions/build.ts
  • packages/agent-core/src/agents/definitions/definitions.test.ts
  • packages/agent-core/src/agents/definitions/discussion.ts
  • packages/agent-core/src/agents/definitions/lead.ts
  • packages/agent-core/src/agents/factory.test.ts
  • packages/agent-core/src/agents/factory.ts
  • packages/agent-core/src/agents/index.ts
  • packages/agent-core/src/agents/query/loop.test.ts
  • packages/agent-core/src/agents/query/loop.ts
  • packages/agent-core/src/agents/query/recovery.test.ts
  • packages/agent-core/src/agents/query/types.ts
  • packages/agent-core/src/agents/session-agent-manager.test.ts
  • packages/agent-core/src/agents/session-agent-manager.ts
  • packages/agent-core/src/approval-review/index.ts
  • packages/agent-core/src/approval-review/prompt.ts
  • packages/agent-core/src/approval-review/service.test.ts
  • packages/agent-core/src/approval-review/service.ts
  • packages/agent-core/src/approval-review/types.ts
  • packages/agent-core/src/config/config.test.ts
  • packages/agent-core/src/config/index.ts
  • packages/agent-core/src/config/schema.ts
  • packages/agent-core/src/config/server-config-service.test.ts
  • packages/agent-core/src/config/server-config-service.ts
  • packages/agent-core/src/delegation/types.ts
  • packages/agent-core/src/execution/session-execution-manager.test.ts
  • packages/agent-core/src/execution/session-execution-manager.ts
  • packages/agent-core/src/execution/session-tool-batch-scheduler.test.ts
  • packages/agent-core/src/index.ts
  • packages/agent-core/src/lead-architecture-flows.integration.test.ts
  • packages/agent-core/src/llm/constants.ts
  • packages/agent-core/src/llm/index.ts
  • packages/agent-core/src/llm/run-object.test.ts
  • packages/agent-core/src/llm/run-object.ts
  • packages/agent-core/src/llm/types.ts
  • packages/agent-core/src/main.test.ts
  • packages/agent-core/src/models/model-selection-resolver.test.ts
  • packages/agent-core/src/multi-agent-control-plane.integration.test.ts
  • packages/agent-core/src/runtime-approval-review.test.ts
  • packages/agent-core/src/runtime.ts
  • packages/agent-core/src/session-input/service.test.ts
  • packages/agent-core/src/session-input/service.ts
  • packages/agent-core/src/store/errors.ts
  • packages/agent-core/src/store/helpers.test.ts
  • packages/agent-core/src/store/helpers.ts
  • packages/agent-core/src/store/index.ts
  • packages/agent-core/src/store/projection.test.ts
  • packages/agent-core/src/store/projection.ts
  • packages/agent-core/src/store/session-store-manager.test.ts
  • packages/agent-core/src/store/session-store-manager.ts
  • packages/agent-core/src/tool-output/live-bash.integration.test.ts
  • packages/agent-core/src/tool-output/user-story.integration.test.ts
  • packages/agent-core/src/tools/builtins/background-output.test.ts
  • packages/agent-core/src/tools/builtins/background-output.ts
  • packages/agent-core/src/tools/builtins/cancel-session.test.ts
  • packages/agent-core/src/tools/builtins/cancel-session.ts
  • packages/agent-core/src/tools/builtins/index.ts
  • packages/agent-core/src/tools/builtins/list-agents.test.ts
  • packages/agent-core/src/tools/builtins/list-agents.ts
  • packages/agent-core/src/tools/builtins/model-visible-contract.test.ts
  • packages/agent-core/src/tools/builtins/send-message.test.ts
  • packages/agent-core/src/tools/builtins/send-message.ts
  • packages/agent-core/src/tools/builtins/wait-for-reminder.test.ts
  • packages/agent-core/src/tools/builtins/wait-for-reminder.ts
  • packages/agent-core/src/tools/names.ts
  • packages/agent-core/src/tools/registry.test.ts
  • packages/agent-core/src/tools/registry.ts
  • packages/agent-core/src/tools/test-approval-reviewer.ts
  • packages/agent-core/src/tools/test-registry.ts
  • packages/agent-core/src/tools/types.ts
  • packages/protocol/src/agent-tree.ts
  • packages/protocol/src/guards.test.ts
  • packages/protocol/src/guards.ts
  • packages/protocol/src/index.ts
  • packages/protocol/src/reduce.test.ts
  • packages/protocol/src/reduce.ts
  • packages/protocol/src/tools.test.ts
  • packages/protocol/src/tools.ts
  • packages/protocol/src/types.test.ts
  • packages/protocol/src/types.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown

This PR has 11,322 reviewable changed lines after ignored/generated files are excluded, above this repository's 10,000-changed-line automatic review limit.

Most of the diff comes from:

  • packages/agent-core/src/execution/session-execution-manager.ts (~1,554 changed lines)
  • packages/agent-core/src/execution/session-execution-manager.test.ts (~1,393 changed lines)
  • packages/agent-core/src/multi-agent-control-plane.integration.test.ts (~824 changed lines)
  • packages/agent-core/src/approval-review/service.test.ts (~699 changed lines)
  • packages/agent-core/src/store/session-store-manager.ts (~399 changed lines)

Comment @cubic-dev-ai review this to review it anyway. If the largest files are generated or fixture data, add them to your ignored files in review settings or ignorePatterns in cubic.yaml - cubic will then review the rest automatically. You can also raise this limit in review settings.

@boh5

boh5 commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@boh5

boh5 commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

@cubic-dev-ai review this

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this

@boh5 I can't start this review because your workspace has reached its free monthly review limit. cubic has reviewed 42,862 of the 40,000 allowed lines of code this month. Reviews resume on 1 September 2026 (in 11 days). Paid plans include much higher monthly review limits. Upgrade now to resume reviews.

To help optimise your usage, you can tune cubic to get the most out of your usage limits:

Learn more →

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review skipped: 119 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@boh5
boh5 merged commit 3ed3eb1 into main Aug 21, 2026
7 checks passed
@boh5
boh5 deleted the codex/multi-agent-control-plane branch August 21, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant