controller: mark nodes stuck rebooting as degraded - #159
Merged
Conversation
Add rollout.rebootTimeoutSeconds so a node that stays in Rebooting past the timeout is reported degraded at the pool level, and 2+ such nodes halt the rollout. Assisted-by: AI Signed-off-by: Prachiti Talgulkar <ptalgulk01@users.noreply.github.com>
ptalgulk01
force-pushed
the
reboot-timeout-degraded
branch
from
September 7, 2026 11:36
ec9059d to
7040478
Compare
alicefr
approved these changes
Sep 7, 2026
Collaborator
|
It looks great, many thanks for this work! Nice coverage also with the env tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
spec.rollout.rebootTimeoutSecondsto BootcNodePool. If a node stays inthe
Rebootingstate longer than this (e.g. it failed to boot the new image ornever rejoined the cluster), the controller reports it as degraded at the pool
level (
degradedCount+Degraded/NodeDegraded). If 2+ nodes time out, therollout halts (
Degraded/RolloutHalted).The field is optional; when unset the controller waits indefinitely, so existing
behavior is unchanged.
Why
Today a node that reboots and never comes back sits in
Rebootingforever. Thedaemon can't report it (the node is down), so nothing surfaces the failure and
the reboot slot is held indefinitely. This covers issue #69 item 4 and the
"cross-distro bad image" scenario.
Fixes: #158
How it works
driveRolloutreclassifies timed-outRebootingnodes into the degradedbucket and requeues the pool so the timeout fires without needing an event.
findUnhealthySlotscounts timed-out nodes toward the halt threshold — a nodethat failed to boot the target is a strong signal the image is bad, which is
what the halt is meant to catch.
Design note
The controller reports at the pool level only. It has read-only access to
bootcnodes/status, and the daemon owns that condition (it auto-clears Degradedon recovery). Marking the BootcNode's own condition would need an RBAC change and
a second writer for daemon-owned status. Happy to go that route instead if
maintainers prefer — flagging it here for input.
Testing
Unit tests for the timeout decision and slot classification, plus envtests for
the pool-degraded and rollout-halt paths.
Assisted-by: AI