expose baseURL to cli commands#199
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request exposes the resolved lesson base URL to CLI command steps via the ${baseURL} interpolation variable, intended to reflect the lesson default or a user-configured override.
Changes:
- Populate the per-run interpolation variables map with
baseURLbefore executing CLI/HTTP steps. - Add a unit test asserting
${baseURL}is interpolated into CLI commands for both default and overridden base URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| checks/runner.go | Adds baseURL into the shared interpolation variable map used by CLI command execution. |
| checks/runner_test.go | Introduces a test to verify ${baseURL} interpolation in CLI command steps for default vs override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theodore-s-beers
force-pushed
the
tsb_base_url
branch
from
c8896f4 to
bdcd590
Compare
theodore-s-beers
force-pushed
the
tsb_base_url
branch
from
bdcd590 to
8951075
Compare
theodore-s-beers
force-pushed
the
tsb_base_url
branch
from
8951075 to
e232e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the resolved lesson base URL to CLI command steps as
${baseURL}, including configured overrides.