Expire session logs older than the retention window - #17
Merged
Conversation
Every run wrote a new timestamped log into ManagedBootstrap\logs and nothing ever removed one, so the directory grew for the life of the machine -- several hundred files after a year of nightly runs. Sweep on Initialize, keyed on last write time rather than the file name: the same directory collects logs from wrapper scripts that do not use the timestamped naming, and those need expiring too. Best-effort throughout; a log held open elsewhere is skipped and retried next run, and no failure here can stop a bootstrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Logger.Initializecreated a newyyyy-MM-dd-HHmmss.logon every run and nothing ever removed one, soC:\ProgramData\ManagedBootstrap\logsgrew for the life of the machine — several hundred files after a year of nightly runs.BootstrapMateConstants.LogRetentionDays(30) sits beside theLogDirectoryconstant it governs.Logger.PruneExpiredLogsruns fromInitialize, right after the new log path is chosen.LogRetentionDaysdisables the sweep.No test project exists in this repo, so this is verified by build and inspection only.