tests: benchmark crud json-lines: io throughput may round to 0 - #10066
Merged
ThomasWaldmann merged 1 commit intoAug 9, 2026
Merged
Conversation
io is int(bytes/second); with the test's 1-byte samples it is 0 whenever an operation takes >= 1 second, which happens on slow, loaded CI VMs (seen on OpenBSD with 4 pytest-xdist workers). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10066 +/- ##
==========================================
- Coverage 86.75% 86.65% -0.11%
==========================================
Files 98 98
Lines 17098 17099 +1
Branches 2590 2589 -1
==========================================
- Hits 14834 14817 -17
- Misses 1570 1588 +18
Partials 694 694 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_benchmark_crud_json_linesassertsentry["io"] > 0, butioisint(total_size / dt)— with the test's 1-byte samples it rounds to 0 whenever a CRUD operation takes ≥ 1 second. Seen failing on a loaded OpenBSD CI VM with 4 pytest-xdist workers in the PR #10064 CI run (the op took just over a second; everything else passed).Relax the assertion to
>= 0with a comment; the type check stays.🤖 Generated with Claude Code