check: summarize findings and repairs - #9891
Conversation
…air counts in ArchiveChecker and print them at the end of the archive consistency check.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9891 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.03%
==========================================
Files 93 93
Lines 15570 15595 +25
Branches 2357 2365 +8
==========================================
+ Hits 13273 13291 +18
- Misses 1598 1604 +6
- Partials 699 700 +1 ☔ View full report in Codecov by Harness. |
|
@charmikadi Thanks for helping with this! Just be aware that @mr-raj12 is currently working on packs and that might need bigger changes in |
|
@mr-raj12 Check this, please. |
|
Thanks for working on this, @charmikadi! My repo repair PR #10048 is landing soon and it rewrites this same check() finish region in repository.py (the "repository repair not implemented" line goes away) and also ArchiveChecker.finish(), so this PR currently conflicts with master there and it's around 330 commits behind. Would suggest rebasing onto latest master and narrowing this to only the archive-side summary for now, and we can add the repository-side repairs count once #10048 is merged. I'll reuse your counting approach and credit you when I do the follow-up. |
Description
borg checkalready reports individual problems as it finds them, but it was hard to tell at a glance how many issues there were overall, or how many--repairactually fixed.This adds a short summary at the end of the check:
Also updated a few repair tests to cover the new summary lines.
Fixes #2397
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)