fix(overwatch): Fix when a coding agent hangs for a long time - #707
Merged
Conversation
Greptile SummaryThe PR prevents coding-agent executions from hanging indefinitely by redirecting agent streams to a sandbox log and adding a client-side deadline around sandbox commands.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The new deadline cleanly propagates failures into unconditional sandbox teardown, while agent executions are sequential within isolated sandboxes and redirected logs are read only after the command completes.
|
| Filename | Overview |
|---|---|
| overwatch/src/agents.ts | Centralizes Claude and Codex execution through prompt staging, detached standard streams, file-backed logging, and existing timeout propagation. |
| overwatch/src/control-loop.ts | Wraps sandbox command requests in the new client-side deadline while preserving the configured server timeout. |
| overwatch/src/sandbox.ts | Adds a generic deadline race with a 60-second grace period and proper timer cleanup. |
| overwatch/src/agents.test.ts | Covers prompt staging, stream redirection, API credentials, timeout forwarding, and error-output selection for both agents. |
| overwatch/src/sandbox.test.ts | Covers timely resolution and rejection, grace-window expiration, and disabled deadlines for non-positive timeout values. |
Reviews (1): Last reviewed commit: "fix(overwatch): Fix when a coding agent ..." | Re-trigger Greptile
Davidferl
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.