fix(rca): require explicit user approval before applying RCA fix suggestions#317
Merged
Merged
Conversation
…estions The fetchRCA tool returns a suggested fix that the consuming agent may act on. Frame the fix as a proposal and gate it behind explicit user approval so no code changes are applied automatically: - format-rca.ts: relabel "Recommended Fix" as a proposal and append an approval-gate directive when a fix is suggested - rca-agent.ts: tighten the fetchRCA prompt to state fixes are suggestions only and require explicit user approval - README.md: document that RCA fixes are proposals requiring approval - add tests for the approval-gate behavior Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ruturaj-browserstack
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
When a user fetches RCA (Root Cause Analysis) for a test via
fetchRCA, the returned analysis may include a suggested code fix. Today that fix is labeled "Recommended Fix", which can nudge a consuming agent to apply the change automatically.This PR makes the suggested fix a proposal only — the assistant must present it and wait for explicit user approval before editing any files. No code change is applied automatically.
The MCP server itself never edits files; the consuming agent does. So the reliable lever is the tool's returned content (read at action time) and the tool prompt — both are updated here.
Changes
src/tools/rca-agent-utils/format-rca.ts**Recommended Fix:**→**Suggested Fix (proposal only — do not apply without explicit user approval):**.src/tools/rca-agent.tsfetchRCAtool prompt to state fixes are suggestions only and require explicit user approval.README.mdtests/tools/formatRCAData.test.ts(new)rcaAgent.test.tsmocksformat-rca, so a dedicated unmocked test file was added.)Testing
npm run buildpasses locally — lint, format, all 185 tests (3 new), andtscall green.🤖 Generated with Claude Code