fix(util): recognize *.bsstag.com hosts as BrowserStack (v8, SDK-6948) - #183
Open
AakashHotchandani wants to merge 1 commit into
Open
fix(util): recognize *.bsstag.com hosts as BrowserStack (v8, SDK-6948)#183AakashHotchandani wants to merge 1 commit into
AakashHotchandani wants to merge 1 commit into
Conversation
getCloudProvider and isBrowserstackInfra only matched browserstack.com, so a session against an internal staging env (*.bsstag.com) was classified as non-BrowserStack — the service skipped its instrumentation + GRR host rewriting and the WebDriver hub stayed on prod. Recognize bsstag/.bsstag.com in both guards. Ports #56/#65 (main/v9) to the v8 release line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AakashHotchandani
requested review from
07souravkunda and
vivianludrick
and removed request for
a team
September 7, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the
*.bsstag.comhost-recognition fix (#56 / #65, which targetmain/v9) to the v8 release line.getCloudProviderand theisBrowserstackInfraisBrowserstackhelper only matchedbrowserstack.com, so a session pointed at an internal staging env (*.bsstag.com) is classified as non-BrowserStack. The service then skips its instrumentation + GRR host rewriting (updateURLSForGRR), and the WebDriver hub stays on production.Change (
packages/browserstack-service/src/util.ts)getCloudProvider: both hostname checks now also matchbsstag.isBrowserstackInfra→isBrowserstack(str): nowstr.includes('browserstack.com') || str.includes('bsstag.com').(Note: v8's
isBrowserstackuses.includes()where v9 uses=== / endsWith; adapted to the v8 form.)Why v8
Internal staging consumers (e.g. App LCA /
devapplca) run on WebdriverIO v8 (@wdio/browserstack-service8.49.x/8.50.0), so the main/v9 PRs don't reach them. This unblocks staging-env WDIO runs on the v8 line.Ref: SDK-6948 · binary #1559 · wdio #56/#65 (main/v9).
🤖 Generated with Claude Code