Bump qs from 6.14.1 to 6.15.3 - #160
Conversation
There was a problem hiding this comment.
The installed dependency version does not match the update this PR advertises; the blocking detail is inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 7749, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
| "version": "6.14.1", | ||
| "resolved": "https://registry.npmjs.org/qs/-/qs-6.14.1.tgz", | ||
| "integrity": "sha512-4EK3+xJl8Ts67nLYNwqw/dsFVnCf+qR7RgXSK9jEEm9unao3njwMDdmsdvoKBKHzxd7tCYz5e5M+SnMjdtXGQQ==", | ||
| "version": "6.14.2", |
There was a problem hiding this comment.
Blocking: This resolves qs to 6.14.2, so merging the PR will not install the advertised 6.15.3 or any of its 6.15.x fixes. npm ls qs --all confirms that both consumers use 6.14.2; @cypress/request@3.0.10 currently constrains it to ~6.14.1. Please either produce a lockfile that includes 6.15.3 (and handle that constraint) or retarget the PR to the 6.14.2 update it actually contains.
There was a problem hiding this comment.
Still open — the lockfile continues to resolve qs to 6.14.2, so this still does not install the advertised 6.15.3.
Bumps [qs](https://github.com/ljharb/qs) from 6.14.1 to 6.15.3. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.1...v6.15.3) --- updated-dependencies: - dependency-name: qs dependency-version: 6.15.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
343e29c to
ff3f5d5
Compare
There was a problem hiding this comment.
The existing blocking thread remains open; I found no new issues in this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 15310, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Bumps qs from 6.14.1 to 6.15.3.
Changelog
Sourced from qs's changelog.
Commits
18d085ev6.15.3c38af42[Deps] updateside-channeladce539[Dev Deps] updateeslint,mock-property,tape74a0f6a[Robustness]utils: enforcearrayLimitconsistently acrossmerge's arra...f4938f5[Tests]parse: characterize current lenient handling of unbalanced bracket ...5d5f723[Perf]utils: makecompactO(n) via a side-channel visited-set instead of...52afe00[Robustness]parse: throw thearrayLimiterror before splitting oversized...963e538[Fix]parse: enforcethrowOnLimitExceededfor cumulative array growth via...59da434[Fix]utils: respect encoding of surrogate pairs across chunks9532969[Robustness]utils.merge/utils.assign: avoid invoking__proto__sette...