Support pinning forked Go modules#167
Open
floze-the-genius wants to merge 2 commits into
Open
Conversation
Signed-off-by: Floze <88098863+floze-the-genius@users.noreply.github.com>
Signed-off-by: Floze <88098863+floze-the-genius@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110.
What changed
replacedirective from the declared path to the forkgo.modafter reading its directivesypresto/CompileDaemonfork from the issuebenchstat@latesttest on Go 1.24 because the current x/perf latest now requires Go 1.25; the case still runs on Go 1.25Why
Bingo resolved the fork version, but generated a direct requirement for the fork repository path. Go then rejected the module because its
go.modstill declares the upstream path. Using the declared path plus a versionedreplacepreserves the real fork revision and makes bothbingo getand generated helper builds work.The benchstat guard only stabilizes the existing Go 1.24 CI lane after an external dependency drift. The new fork regression still runs on Go 1.24 and Go 1.25 on both supported platforms.
Validation
gofmt -w get.go get_e2e_test.goGOTOOLCHAIN=go1.24.13 make testmake testgo vet -stdmethods=false ./...make lintCodex disclosure
This PR was prepared by OpenAI Codex at the contributor direction. Codex performed the repository and issue preflight, implementation, regression testing, CI log analysis, and local validation reported above.