Catch OutOfMemoryError at WasmGC allocation sites - #149
Open
andreaTP wants to merge 2 commits into
Open
Conversation
Convert OutOfMemoryError to WasmEngineException("out of memory") in
all GC allocation instructions (struct.new, struct.new_default,
array.new, array.new_default, array.new_fixed, array.new_data,
array.new_elem) across the interpreter, compiler runtime, and
constant expression evaluator paths.
Follows the existing StackOverflowError precedent.
Refs: bytecodealliance#102
Contributor
Author
|
@philip-segerfast if you can try your stress tests with those changes let me know the results. The idea is that it shouldn't be possible to trigger a plain Java OOM from inside a Wasm module, we should identify the condition and report the caller with a specific Wasm Exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert OutOfMemoryError to WasmEngineException("out of memory") in all GC allocation instructions (struct.new, struct.new_default, array.new, array.new_default, array.new_fixed, array.new_data, array.new_elem) across the interpreter, compiler runtime, and constant expression evaluator paths.
Follows the existing StackOverflowError precedent.
Refs: #102