Skip to content

Throw dedicated exception instead of RuntimeException #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreaTP merged 1 commit into from
Aug 13, 2026
+4 −3
Merged

Throw dedicated exception instead of RuntimeException #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/src/main/java/run/endive/compiler/internal/TypeStack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import java.util.Deque;
import java.util.HashMap;
import java.util.Map;
import run.endive.wasm.InvalidException;
import run.endive.wasm.types.FunctionType;
import run.endive.wasm.types.Instruction;
import run.endive.wasm.types.OpCode;
Expand Down Expand Up @@ -91,10 +92,10 @@ public Deque<ValType> types() {

public void verifyEmpty() {
if (types.size() != 1) {
throw new RuntimeException("Bad types stack: " + types);
throw new InvalidException("Bad types stack: " + types);
}
if (!types().isEmpty()) {
throw new RuntimeException("Types not empty: " + types());
throw new InvalidException("Types not empty: " + types());
}
}
}
2 changes: 1 addition & 1 deletion runtime/src/main/java/run/endive/runtime/InterpreterMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ protected void evalDefault(
Instruction instruction,
Operands operands)
throws WasmEngineException {
throw new RuntimeException("Machine doesn't recognize Instruction " + instruction);
throw new WasmEngineException("Machine doesn't recognize Instruction " + instruction);
}

@Override
Expand Down
Loading