docs(scroll): tell the caller what a scroll's movement field means - #2772
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
|
Reviewed at b2ec05f: clean. The help string, the MCP |
b2ec05f to
44f9a26
Compare
|
Reviewed at 44f9a26: clean. The doc fixes from the earlier review landed, and this stays ready for human review once #2771 settles. Not blocking: the website says The CI failures on this branch are cancelled jobs from the stacked base, not results of this diff, which only changes a help string, an MCP enum and a docs page. |
44f9a26 to
ff72009
Compare
|
Done — every absent case is now named on the two agent-facing surfaces. The MCP One thing worth knowing from CI-side validation: my first draft wrote |
|
Reviewed ff72009. The docs still match the Not blocking: this commit also rewrites a recording-quality sentence in commands.md#L1140, and main already has that wording from 92b8fae. It probably came in with the restack. Maybe drop it? |
d1e87c5 to
bfffce2
Compare
bfffce2 to
dc11d38
Compare
dc11d38 to
aa0d725
Compare
|
This looks ready for review at aa0d725. It is a rebase of the reviewed ff72009, and the stray Not blocking: could the absence list in All checks were still queued; this change only edits doc and schema-string text. The live evidence for the movement values is still open on #2771, so this doc should land with or after it. |
aa0d725 to
9835da8
Compare
9835da8 to
6a0661b
Compare
|
Both notes taken, on The The One addition since your review: 🤖 Generated with Apex by Callstack |
6a0661b to
8822561
Compare
|
Reviewed 6a0661b. The docs now describe the container-confined Not blocking: the The failing iOS Smoke Tests assertion (Simulator AX bridge evidence gap) is likely unrelated: this diff only changes description strings, and the same assertion fails on other unrelated PRs today. The head has since moved to 8822561, a rebase onto main in which this commit is patch-identical, so the review above still applies. |
What
movementandscroll_no_progresschange what an agent's next command should be, so every surface that describes the command says so — including when the field is absent, which an agent will otherwise read as "nothing moved".src/commands/interaction/metadata.ts— the versioned description (one string, read by both CLI help and the MCP tool description) names the four observations, the refusal, and the three absence cases. Flag-free wording, becausecommand-surface-metadata.test.tsrefuses CLI syntax in the MCP body (it caught my first draft).src/mcp/command-output-schemas.ts— thescrolloutput object was missingmovementwhile the contract had it. Adds the enum with what each value warrants, and the four places the field is legitimately absent: the tiers that verify per pass (top/bottom,--until), a runtime bound without a capture, a platform whose scroll dispatches no swipe, and callers that own the observation already (--settle, replay withpostGestureStabilization: false).website/docs/docs/commands.md— the same in prose, next to the keyboard-band behaviour it sits against.Both agent-facing texts also carry the case this round added:
movedis a claim about the scroller the swipe ran in, and a difference that sits only outside it answersunobservedrather than crediting the gesture. And the site no longer saysunobservedcovers "no capture on this runtime" — that case carries nomovementfield at all, which the same paragraph already said; the two sentences contradicted each other.Validation
--qualityrecording sentence (a restack artifact against main's92b8fae) is dropped.pnpm check:command-docs(12/12),pnpm check:mcp-metadata --check, andpnpm check:affected --runat the stack head882256121all pass;pnpm check:fallow --base fix/scroll-observed-movementreports no issues.Docs-only; no device evidence needed here. #2771 carries the live run.
🤖 Generated with Apex by Callstack