refactor(ios): one simctl --set builder and one simulator state parser

[thymikee]

Summary

Stacked on #2818.

Closes #2794. core/simctl.ts now builds every simctl --set prefix: scopeSimctlArgs* for the appleTools host seam and buildSimctlArgs* for xcrun. Every direct run goes through runSimctlForDevice.

Removed:

• the runSimctl/simctlArgs alias. apps-simctl.ts is deleted and its one helper moved into its only caller.
• simulator-state.ts's builder.
• the screenshot and status-bar shims.
• the inline prefixes in network, logs and log-predicate.

The two state parsers now share readSimctlDeviceState in core/simctl-device-list.ts, and the snapshot target's runtime reads through the same raw reader. Inventory keeps its own strict projection.

No argv changes: existing argv tests are unchanged apart from two vi.mock paths. One discrepancy: former simulator-state.ts call sites now trim the set path and skip non-simulators, but they run on simulators only. ADR 0023's dated hop trace was left as is. 25 files touched.

Validation

Tested SHA 47edaa927e46de4353be426dd5e2c962260c6ddd. Passed:

• pnpm check:affected --run: 13 checks; 3133 related tests
• pnpm check:fallow
• pnpm check:production-exports
• pnpm check:layering
• git grep "'--set'": only core/simctl.ts among production files

No live device: argv is unchanged, so the Apple CI lanes cover this.

Review (8 findings): fixed 2, the misnamed apps-simctl.ts and a wrong throw doc. Rejected 6, which were pre-existing behaviour, an intentional strict inventory, differing transports, or an argv-test constraint.

Risk: host-seam modules (inventory, shutdown, logs) now statically reach tool-provider through core/simctl.ts. That is about 12 more modules, all already resident in the daemon.

🤖 Generated with Claude Code

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	4.79 MB	4.79 MB	-537 B
Package (unpacked)	4.79 MB	4.79 MB	-537 B
Package (download)	1.43 MB	1.43 MB	-154 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	27.8 ms	27.0 ms	-0.7 ms
CLI --help	79.5 ms	77.9 ms	-1.6 ms

[thymikee]

Reviewed at 47edaa9. The consolidation reads well: every --set prefix now comes from core/simctl.ts, and the rewritten call sites produce the same argv for every reachable input. The diff is already small (+1 production line net, with one file, one alias and three shims deleted). The one smaller shape I see: could readSimctlDevicesByRuntime and readSimctlDeviceState live in core/simctl.ts instead of a new simctl-device-list.ts? Is there a reason they need their own file?

That same move would fix the Coverage failure, which this diff causes. The eager-closure budget test names the new edge core/simulator.ts -> core/simctl-device-list.ts, added at https://github.com/callstack/agent-device/blob/47edaa9/packages/platform-apple/src/core/simulator.ts#L16. It grows the closure of simulator-facade.ts from 24 to 25 modules. core/simulator.ts, simulator-state.ts and snapshot-target.ts already import core/simctl.ts, so moving the readers there adds no new edge.

A small note: simulator-state.ts now reaches runXcrun statically through core/simctl.ts only to get an argv builder. The PR body calls this out, and it stays inside the budgets.

Smoke Tests and both CodeQL jobs were still running when I looked. Smoke Tests exercises the simctl routes this PR rewrites, so please check its result when it finishes.

[thymikee]

Reviewed at c8cb34e. The code looks right, with no findings in the diff.

The evidence question from the earlier review is still open. Smoke Tests at this commit fails in smoke:automation-input step 7 (wait text Agent Device Tester, wait_capture_stalled with one capture). That route goes through scopeSimctlArgsForDevice and runSimctlForDevice, which this PR rewrites. The argv and parse results look the same before and after, so this looks like the known first-capture stall (#2838 targets it), but the run does not prove it.

The next step is a green iOS Smoke run at c8cb34e, or a re-run that gets past step 7.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-23 16:56 UTC