test(ios): expect the AX bridge to derive hittability in the depth-frontier E2E - #2832
Merged
Merged
Conversation
…ontier E2E #2775 made the Simulator AX bridge stamp geometric hittable and disclose the hittability gap only when no viewport is reported. The live depth-frontier scenario still required the old gap warning on every bridge capture, so every iOS Smoke run on main and on rebased PRs failed after #2775 merged. Assert the new contract instead: a bridge capture with a viewport carries no hittability-gap warning, and the on-screen projected child is hittable.
Size Report
Startup median (7 runs, lower is better):
|
This was referenced Sep 23, 2026
Merged
Member
Author
|
Reviewed at fe2cbb8. The new assertions in Smoke Tests was still queued at review time. This PR changes exactly the failing assertion, so a green iOS Smoke run on this head is the proof it needs. |
This was referenced Sep 23, 2026
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every iOS Smoke Tests run on
mainand on rebased PRs fails atsmoke:regular-visible-depth-frontierwithregular depth-1 snapshot must disclose the Simulator AX bridge evidence gap(22 failed jobs on 17 branches today, including #2825 and #2820).#2775 made the AX bridge derive geometric
hittableand disclose the hittability gap only when no viewport is reported. The live scenario still required the old gap warning on every bridge capture. #2775 merged with this job red.The scenario now asserts the #2775 contract: a bridge capture that has a viewport carries no hittability-gap warning, and the on-screen projected child is
hittable: true. Test-only; 2 files.Validation
fe2cbb8fd2:pnpm check:affected --runpassed (format, lint, typecheck, fallow, related vitest).fingerprint.d6b4c1f5….ios, repacked with current JS) on a fresh iPhone 17 Pro / iOS 26.2 simulator;assertRegularVisibleDepthFrontierpassed 3 of 3 consecutive runs. The pre-fix assertion fails on the same capture shape CI logged (hittable:truechild, nowarnings).