Skip to content

test(ios): stop cold-host timing from failing the occupancy test #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Sep 24, 2026
Merged

test(ios): stop cold-host timing from failing the occupancy test #2847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...er/AgentDeviceRunnerUITests/UnitTests/RunnerTests+SnapshotCapturePlanOccupancyTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,13 @@ private enum RunnerBlockingSnapshotGate {
/// read the AX server gave up on. The swap is process-wide while installed, which serial XCTest
/// execution tolerates.
private final class RunnerBlockingSnapshotStub: NSObject {
/// Far past the plan deadline, so only the test's own release ends the block; it only stops a
/// stuck test from holding the main thread.
private static let leakGuard: TimeInterval = 75

@objc(snapshotWithError:)
func snapshot() throws -> XCUIElementSnapshot {
_ = RunnerBlockingSnapshotGate.release.wait(timeout: .now() + 20)
_ = RunnerBlockingSnapshotGate.release.wait(timeout: .now() + Self.leakGuard)
throw NSError(
domain: "AgentDeviceRunner.tests",
code: 1,
Expand Down Expand Up @@ -50,6 +54,10 @@ extension RunnerTests {
// resolution is slow, and it must not be the block the plan abandons.
XCTAssertTrue(app.wait(for: .runningForeground, timeout: 10))
XCTAssertFalse(app.frame.isEmpty)
// The traversal context reads the viewport under a 1 s cap; a cold first read can overrun it
// and abandon the wrong block, so pay it here, uncapped.
_ = safeSnapshotViewport(app: app)
_ = capturedInterfaceOrientation(app: app)
currentApp = app
currentBundleId = "com.callstack.agentdevice.runner.tree-capture-test"
snapshotXCTestPenaltyWarmupExemptionPending = true
Expand Down
Loading