Skip to content

refactor(move): move the runner's inline unit tests into UnitTests/ #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Sep 24, 2026
Merged

refactor(move): move the runner's inline unit tests into UnitTests/ #2854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5785e20
refactor(move): move the runner's inline unit tests into UnitTests/
thymikee Sep 23, 2026
61fcc69
chore(gates): describe the runner's test membership without the moved…
thymikee Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 4 additions & 165 deletions apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerScrollViewportPolicy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import AgentDeviceSnapshotPresentation
//
// The pure rule below is geometry on purpose — no XCUIApplication — so its exact decision is proven
// against the golden table shared with its TS twin, `clipScrollViewportAboveKeyboard` in
// packages/contracts/src/scroll-gesture.ts, asserted in that file's test beside this one. The table
// carries only frames representable in both languages: `CGRect` standardizes a negative extent into a
// positive height at a moved origin, so a negative `height` is tested on the TS side alone.
// packages/contracts/src/scroll-gesture.ts, asserted in that file's test and in
// UnitTests/RunnerTests+ScrollViewportPolicyTests.swift. The table carries only frames
// representable in both languages: `CGRect` standardizes a negative extent into a positive height
// at a moved origin, so a negative `height` is tested on the TS side alone.
//
// The `extension RunnerTests` below is the one impure caller: it reads the runner's own live keyboard
// frame, because a frame threaded from the daemon would predate the keyboard.
Expand Down Expand Up @@ -248,165 +249,3 @@ extension RunnerTests {
}
#endif
}

#if AGENT_DEVICE_RUNNER_UNIT_TESTS
private struct ScrollViewportPolicyFixture: Decodable {
struct Frame: Decodable {
let x: Double
let y: Double
let width: Double
let height: Double

var cgRect: CGRect {
CGRect(x: x, y: y, width: width, height: height)
}
}

struct Constants: Decodable {
let minVisibleFraction: Double
let accessoryAllowance: Double
}

struct Expected: Decodable {
let kind: String
let viewport: Frame?
let keyboardMinY: Double?
let visibleHeight: Double?
}

struct TestCase: Decodable {
let name: String
let viewport: Frame
let keyboard: Frame
let expected: Expected
}

let constants: Constants
let cases: [TestCase]
}

extension RunnerTests {
/// Golden parity table (#2500): every case in contracts/fixtures/scroll-keyboard-policy.json must
/// agree with the vitest twin. Add cases there, never fork the rule.
func testScrollViewportKeyboardClipMatchesGoldenParityTable() throws {
let fixture = try loadScrollViewportPolicyFixture()
XCTAssertFalse(fixture.cases.isEmpty, "parity table must not be empty")
for testCase in fixture.cases {
let clip = ScrollViewportPolicy.clip(
viewport: testCase.viewport.cgRect,
keyboard: testCase.keyboard.cgRect
)
switch testCase.expected.kind {
case "unobstructed":
XCTAssertEqual(clip, .unobstructed, testCase.name)
case "avoided":
let expectedFrame = try XCTUnwrap(testCase.expected.viewport, testCase.name).cgRect
let expectedMinY = try XCTUnwrap(testCase.expected.keyboardMinY, testCase.name)
XCTAssertEqual(
clip,
.avoided(frame: expectedFrame, keyboardMinY: expectedMinY),
testCase.name
)
case "occluded":
let expectedMinY = try XCTUnwrap(testCase.expected.keyboardMinY, testCase.name)
let expectedVisibleHeight = try XCTUnwrap(testCase.expected.visibleHeight, testCase.name)
XCTAssertEqual(
clip,
.occluded(keyboardMinY: expectedMinY, visibleHeight: expectedVisibleHeight),
testCase.name
)
default:
XCTFail("unknown expected kind `\(testCase.expected.kind)` in \(testCase.name)")
}
}
}

/// The thresholds are the table's, not this file's. The refusal reason and the runner code are
/// each one side's own vocabulary: the reason is what the host publishes, the code is what this
/// runner answers with, and neither is a shared clip constant.
func testScrollViewportPolicyUsesParityTableConstants() throws {
let constants = try loadScrollViewportPolicyFixture().constants
XCTAssertEqual(constants.minVisibleFraction, ScrollViewportPolicy.minVisibleFraction)
XCTAssertEqual(constants.accessoryAllowance, ScrollViewportPolicy.accessoryAllowance)
}

/// A clipped landscape band shortens the frame, and `CoordinateSpaceRotation.native(point:)` derives a
/// `landscapeRight` native x from the frame's HEIGHT. Rotating inside the band therefore moves the
/// dispatched path sideways by exactly what the keyboard took, off the lane the plan was built for,
/// so the plan band and the coordinate basis stay separate values through dispatch (#2500).
func testScrollViewportDispatchKeepsTheUnclippedFrameAsItsCoordinateRotationBasis() throws {
let viewport = CGRect(x: 0, y: 0, width: 1210, height: 834)
let keyboard = CGRect(x: 0, y: 588, width: 1210, height: 246)
let clip = ScrollViewportPolicy.clip(viewport: viewport, keyboard: keyboard)
guard case .avoided(let band, let keyboardMinY) = clip else {
return XCTFail("expected a landscape keyboard to be avoided, got \(clip)")
}
XCTAssertEqual(band.height, 576)

guard case .gesture(let gesture) = ScrollViewportPolicy.frames(
referenceFrame: viewport,
clip: clip
).gestureDispatch(direction: .up, amount: nil, pixels: nil) else {
return XCTFail("expected a gesture inside the clipped band")
}
XCTAssertEqual(gesture.planFrame, band)
XCTAssertEqual(gesture.keyboardMinY, keyboardMinY)
XCTAssertEqual(gesture.coordinateFrame, viewport, "the rotation basis must survive the clip")
XCTAssertLessThanOrEqual(
max(gesture.plan.y1, gesture.plan.y2),
keyboard.minY - ScrollViewportPolicy.accessoryAllowance,
"a landscape swipe must stay clear of the keys"
)

let reported = gesture.attachingEvidence(
to: Response(
ok: true,
data: DataPayload(referenceWidth: viewport.width, referenceHeight: viewport.height),
error: nil
)
)
XCTAssertEqual(
reported.data?.referenceHeight,
band.height,
"the payload names the band the plan ran inside, not the synthesis frame"
)
XCTAssertEqual(reported.data?.referenceWidth, viewport.width)
XCTAssertEqual(reported.data?.keyboardMinY, keyboardMinY)
XCTAssertEqual(reported.data?.keyboardAvoided, true)

let orientedStartY = gesture.planFrame.minY + gesture.plan.y1
let dispatchedFromViewport = CoordinateSpaceRotation.native(
point: CGPoint(x: gesture.planFrame.minX + gesture.plan.x1, y: orientedStartY),
in: gesture.coordinateFrame,
interfaceOrientation: RunnerInterfaceOrientation.landscapeRight
)
let dispatchedFromBand = CoordinateSpaceRotation.native(
point: CGPoint(x: gesture.planFrame.minX + gesture.plan.x1, y: orientedStartY),
in: gesture.planFrame,
interfaceOrientation: RunnerInterfaceOrientation.landscapeRight
)
XCTAssertEqual(
dispatchedFromViewport.x - dispatchedFromBand.x,
viewport.height - band.height,
accuracy: 0.001,
"rotating inside the clipped band would shift native x by what the keyboard took"
)
}

private func loadScrollViewportPolicyFixture() throws -> ScrollViewportPolicyFixture {
let fixtureURL = URL(fileURLWithPath: #filePath)
.deletingLastPathComponent() // AgentDeviceRunnerUITests
.deletingLastPathComponent() // AgentDeviceRunner
.deletingLastPathComponent() // runner
.deletingLastPathComponent() // apple
.deletingLastPathComponent() // repo root
.appendingPathComponent("contracts")
.appendingPathComponent("fixtures")
.appendingPathComponent("scroll-keyboard-policy.json")
return try JSONDecoder().decode(
ScrollViewportPolicyFixture.self,
from: Data(contentsOf: fixtureURL)
)
}
}
#endif
48 changes: 0 additions & 48 deletions apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerSystemSurfaceHostPolicy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,51 +30,3 @@ enum SystemSurfaceHostRegistry {
host(forBundleId: bundleId) != nil
}
}

#if AGENT_DEVICE_RUNNER_UNIT_TESTS
import XCTest

private struct SystemSurfaceHostFixture: Decodable {
struct Host: Decodable {
let bundleId: String
let kind: String
}
let hosts: [Host]
}

extension RunnerTests {
func testSystemSurfaceHostRegistryMirrorsGoldenFixture() throws {
let fixtureURL = URL(fileURLWithPath: #filePath)
.deletingLastPathComponent() // AgentDeviceRunnerUITests
.deletingLastPathComponent() // AgentDeviceRunner
.deletingLastPathComponent() // runner
.deletingLastPathComponent() // apple
.deletingLastPathComponent() // repo root
.appendingPathComponent("contracts")
.appendingPathComponent("fixtures")
.appendingPathComponent("ios-system-surface-hosts.json")
let fixture = try JSONDecoder().decode(
SystemSurfaceHostFixture.self,
from: Data(contentsOf: fixtureURL)
)
let registry = SystemSurfaceHostRegistry.hosts.map { [$0.bundleId, $0.kind.rawValue] }
let golden = fixture.hosts.map { [$0.bundleId, $0.kind] }
XCTAssertEqual(registry, golden, "SystemSurfaceHostRegistry drifted from the golden fixture")
}

func testSystemSurfaceHostRegistryRecognizesRegisteredHosts() {
XCTAssertTrue(SystemSurfaceHostRegistry.isSystemSurfaceHost("com.apple.SafariViewService"))
XCTAssertTrue(SystemSurfaceHostRegistry.isSystemSurfaceHost("com.apple.PassbookUIService"))
XCTAssertFalse(SystemSurfaceHostRegistry.isSystemSurfaceHost("com.example.app"))
XCTAssertFalse(SystemSurfaceHostRegistry.isSystemSurfaceHost(nil))
XCTAssertEqual(
SystemSurfaceHostRegistry.host(forBundleId: "com.apple.SafariViewService")?.kind,
.webAuth
)
XCTAssertEqual(
SystemSurfaceHostRegistry.host(forBundleId: "com.apple.PassbookUIService")?.kind,
.payment
)
}
}
#endif
50 changes: 0 additions & 50 deletions apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTapPointPolicy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,53 +25,3 @@ enum TapPointPolicy {
&& centerY >= windowFrame.minY && centerY <= windowFrame.maxY
}
}

#if AGENT_DEVICE_RUNNER_UNIT_TESTS
private struct TapPointPolicyFixture: Decodable {
struct Frame: Decodable {
let x: Double
let y: Double
let width: Double
let height: Double

var cgRect: CGRect {
CGRect(x: x, y: y, width: width, height: height)
}
}

let name: String
let elementFrame: Frame
let windowFrame: Frame
let allowed: Bool
}

extension RunnerTests {
// Golden parity table (ADR 0011 Layer 2): every case in
// contracts/fixtures/tap-point-policy.json must agree with the vitest twin
// (tap-point-policy-parity.test.ts). Add cases there, never fork the rule.
func testTapPointPolicyMatchesGoldenParityTable() throws {
let fixtureURL = URL(fileURLWithPath: #filePath)
.deletingLastPathComponent() // AgentDeviceRunnerUITests
.deletingLastPathComponent() // AgentDeviceRunner
.deletingLastPathComponent() // runner
.deletingLastPathComponent() // apple
.deletingLastPathComponent() // repo root
.appendingPathComponent("contracts")
.appendingPathComponent("fixtures")
.appendingPathComponent("tap-point-policy.json")
let data = try Data(contentsOf: fixtureURL)
let cases = try JSONDecoder().decode([TapPointPolicyFixture].self, from: data)
XCTAssertFalse(cases.isEmpty, "parity table must not be empty")
for fixture in cases {
XCTAssertEqual(
TapPointPolicy.isAllowed(
elementFrame: fixture.elementFrame.cgRect,
windowFrame: fixture.windowFrame.cgRect
),
fixture.allowed,
fixture.name
)
}
}
}
#endif
Loading
Loading