Skip to content

ci(diagnose): retire the 1874 diagnose loop - #2875

Merged
thymikee merged 1 commit into
mainfrom
ci/retire-1874-diagnose
Sep 24, 2026
Merged

thymikee merged 1 commit into
mainfrom
ci/retire-1874-diagnose

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Follow-up to the review on #2845. The review noted that 1874-diagnose.yml defaults to testBareTypeUsesTappedInputWhenSoftwareKeyboardIsHidden. After #2845 that test asserts route xctest-element and never reaches a [DEBUG-1874] commit wait. Of the two options (repoint the default or retire the workflow), this PR retires it.

Deleted: the workflow, scripts/diagnose-1874-iteration.ts, its test, and that test's vitest.config.ts entry (4 files, −370). The runner's [DEBUG-1874] lines stay. The #2080 trace came from them in the smoke lane's runner.log, and existing tests pin their format and redaction.

Validation

  • pnpm check:affected --run passed: 59 checks selected (including fallow and build), GitHub-authoritative lanes not run locally. It ran at 120233a7a, which has the same tree as the pushed f6888782f; only the commit message was reworded.
  • pnpm check:xctest-selection: 308 methods, 0 reachable by no lane.
  • git grep finds no leftover references.
  • An adversarial review found no blocking issues. Its two wording corrections are applied above.

🤖 Generated with Claude Code

The loop's default test stopped reaching a commit wait in #2845: it asserts
route xctest-element, so a default dispatch collects no [DEBUG-1874]
cadence. That test never reached #2080's route, even before #2845. It is a
bare `type`, and the synthesized-first-responder-replacement route fires
only for `fill` on a penalized XCTest channel. So this loop was never
#2080's reproduction path.

No existing RunnerTests method reaches the real replacement route. The one
test that reaches its commit wait
(testTypeTextReliablyPacesSynthesizedReplacementThroughProductionCaller)
uses a recording synthesizer against Springboard, so every poll reads nil
and the wait always ends notObserved at the 3 s stall deadline. Looping it
records a fixed, synthetic cadence. A new penalized coordinate-fill test
could reach the route, but the cadence records lengths only (#1924), so it
still could not capture the corrupted value #2080 needs. #2080's triage
asks for a local reproduction with test-only value instrumentation instead.

Delete the workflow, its iteration reader, and that reader's test. The
runner's [DEBUG-1874] lines stay: runner.log in the iOS smoke lane is where
the #2080 trace came from, and existing tests pin their format and
redaction.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.80 MB 4.80 MB 0 B
Package (unpacked) 4.80 MB 4.80 MB 0 B
Package (download) 1.44 MB 1.44 MB -2 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.7 ms 27.7 ms -0.0 ms
CLI --help 82.5 ms 80.7 ms -1.8 ms

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at f688878. The deletion looks clean: it removes the diagnose workflow, the script, its test, and the matching line in vitest.config.ts. It touches no production code.

The failing Smoke Tests job is a live iOS run. It fails at get text id="automation-event-name" because the selector did not match. This diff does not touch that path, so the failure is likely unrelated. I did not check whether it also fails on main, so a re-run or a separate look is worth it.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 24, 2026
@thymikee
thymikee merged commit 57886b3 into main Sep 24, 2026
17 of 18 checks passed
@thymikee
thymikee deleted the ci/retire-1874-diagnose branch September 24, 2026 10:43
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-24 10:44 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant