Skip to content

docs(ios): state the fold's clipped-carrier hittability as false, not nil #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Sep 25, 2026
Merged

docs(ios): state the fold's clipped-carrier hittability as false, not nil #2958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...napshot-presentation/Sources/AgentDeviceSnapshotPresentation/SnapshotVisibilityFold.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,10 @@ public enum SnapshotVisibilityFold {
}

/// The fold's share of the `hittable` policy (#2891). A declared `false` is kept; anything the
/// source left undecided is re-decided on the clipped frame, which refuses a disabled or
/// degenerate node with no viewport to consult and answers `nil` only while containment is the
/// open question. A `visibilityExempt` carrier clipped to nothing by a scroll anchor is that
/// `nil` today, and its own frame already answers the question.
/// source left undecided is re-decided on the clipped frame: a disabled or degenerate frame —
/// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`,

@cubic-dev-ai cubic-dev-ai Bot Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This sentence is ungrammatical and makes the corrected clipping scenario ambiguous. Say that the carrier was clipped to nothing by a scroll anchor.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apple/snapshot-presentation/Sources/AgentDeviceSnapshotPresentation/SnapshotVisibilityFold.swift, line 246:

<comment>This sentence is ungrammatical and makes the corrected clipping scenario ambiguous. Say that the carrier was clipped to nothing by a scroll anchor.</comment>

<file context>
@@ -242,10 +242,10 @@ public enum SnapshotVisibilityFold {
-  /// open question. A `visibilityExempt` carrier clipped to nothing by a scroll anchor is that
-  /// `nil` today, and its own frame already answers the question.
+  /// source left undecided is re-decided on the clipped frame: a disabled or degenerate frame —
+  /// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`,
+  /// and `nil` stays reserved for the one question the clipped frame cannot answer, containment
+  /// while the capture has no viewport box.
</file context>
Suggested change
/// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`,
/// including a `visibilityExempt` carrier clipped to nothing by a scroll anchor — answers `false`,
Fix with cubic

/// and `nil` stays reserved for the one question the clipped frame cannot answer, containment
/// while the capture has no viewport box.
private static func clippedHittability(
source: Bool?,
enabled: Bool,
Expand Down
Loading