Migrate e2e to maestro-runner - #1143
Open
troZee wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
There was a problem hiding this comment.
🟡 Changes recommended
The nested pager Maestro test now launches the app twice back-to-back, which adds avoidable runtime and can increase flakiness.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates the repository’s mobile E2E workflow from the Maestro CLI to maestro-runner, updating the runner script, npm scripts, and a few flows to improve reliability (retries + explicit waits) and artifact output.
Changes:
- Switch
scripts/run-maestro-tests.shto invokemaestro-runnerand validate it’s installed. - Update
package.jsonscripts to usemaestro-runnerand enable retries for platform E2E runs. - Improve flow stability by resetting LTR state in a nested test and adding
extendedWaitUntilguards around scroll-toggle assertions.
File summaries
| File | Description |
|---|---|
| scripts/run-maestro-tests.sh | Replaces maestro test invocation with maestro-runner and adds a preflight install check. |
| package.json | Updates Maestro-related scripts to use maestro-runner and enables retries for platform test runs. |
| .maestro/tests/nested_pagerView_example.yaml | Adds an LTR-reset pre-step before running the nested pager example test. |
| .maestro/README.md | Documents maestro-runner installation and clarifies retry + artifact behavior. |
| .maestro/flows/basic-pager/verify-vertical-swipe.yaml | Adds wait-until-visible guards after toggling scroll state. |
| .maestro/flows/basic-pager/verify-horizontal-rtl-swipe.yaml | Adds wait-until-visible guards after toggling scroll state (RTL). |
| .maestro/flows/basic-pager/verify-horizontal-ltr-swipe.yaml | Adds wait-until-visible guards after toggling scroll state (LTR). |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
6
| - runFlow: ../flows/basic-pager/ensure-ltr.yaml | ||
|
|
||
| - runFlow: ../setup/nested_pagerView_example_setup.yaml | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maestro-runner promises to be a faster, more reliable alternative to the official Maestro CLI. Expo also uses it inside EAS expo/eas-cli#4187
Test Plan
e2e for Android and iOS should pass