Fix recurring tasks missing scheduled date when recurrence is saved - #2202
Open
christenbc wants to merge 2 commits into
Open
Fix recurring tasks missing scheduled date when recurrence is saved#2202christenbc wants to merge 2 commits into
christenbc wants to merge 2 commits into
Conversation
# Conflicts: # docs/releases/unreleased.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleddate is set whenever recurrence is saved, including when the custom recurrence start date is left emptygetRecurrenceSchedulingDefaults()andresolveScheduledDateForRecurrence()Problem
Recurring tasks could be saved with a recurrence rule (and sometimes an auto-filled
DTSTART) but noscheduleddate. TaskNotes could still calculate recurrence internally, but Google Calendar export requiresscheduled/dueand would skip these tasks.This was easy to hit from the custom recurrence dialog when only the repeat pattern was set (e.g. monthly on the 4th) without an explicit start date.
Solution
When recurrence is saved and the task has no
scheduleddate:dateCreatedif neededDTSTARTwhen missing (existing behavior)Test plan
scheduledis written to frontmatterscheduledis setscheduledare unchangednpm test -- --testPathPatterns=taskUpdatePlanning