Conversation
Expose operator notification config with secret redaction, validated PATCH updates, delivery log filters, and relay-named test messages. Closes #760.
🦋 Changeset detectedLatest commit: 08ea9b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Collaborator
Reject persisting redacted placeholders on new targets, add PATCH controller coverage, reload settings in the maintenance worker, and record test deliveries in the delivery log.
11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds admin HTTP API for operator notifications on top of the backend from #759 / #781:
/admin/notifications— currentadmin.notificationsconfig with webhook URLs and tokens redacted/admin/notifications— updateenabled, targets, event toggles, retry policy, and retention; validates like settings; preserves secrets when the client sends***forurl/botToken/admin/notifications/deliveries— optionalstatusandeventTypequery filters (limit validation unchanged)/admin/notifications/test— test message text uses the relay name:Test notification from <name|relay_url>Related Issue
Closes :- #760
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: