Skip to content

cds add xsuaa: "--for production" not required - #2916

Merged
vl-leon merged 2 commits into
mainfrom
cds-add-xsuaa/remove-for-production
Sep 23, 2026
Merged

vl-leon merged 2 commits into
mainfrom
cds-add-xsuaa/remove-for-production

Conversation

@vl-leon

@vl-leon vl-leon commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@hyperspace-pr-bot

hyperspace-pr-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Control Panel

Hi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
To interact with me, just use the following actions:

  • 📝 Summarize PR
  • 🔍 Review
  • 🗑️ Delete all bot comments and reviews

@vl-leon
vl-leon requested a review from swaldmann September 23, 2026 12:44

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no substantive issues in the changed lines. The updates are consistent with the PR intent, though the repository still contains at least one older cds add xsuaa --for production reference in guides/deploy/microservices.md that the author may want to review for follow-up consistency.

PR Bot Information

Version: 1.31.51

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable issues found in the changed lines. The updates consistently remove the now-unneeded --for production flag from the affected XSUAA setup examples.

PR Bot Information

Version: 1.31.51

@swaldmann swaldmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vl-leon
vl-leon added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 654f81d Sep 23, 2026
4 checks passed
@vl-leon
vl-leon deleted the cds-add-xsuaa/remove-for-production branch September 23, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants