Skip to content

fix: refactor projectgraphgenerator to expose read-only graph results #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdsap merged 1 commit into from
Sep 12, 2026
Merged

fix: refactor projectgraphgenerator to expose read-only graph results #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/ProjectGraphGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ProjectGraphGenerator(
private val typeOfProjectRequested: TypeProjectRequested,
private val classesPerModule: ClassesPerModule
) {
fun generate(): MutableList<ProjectGraph> {
fun generate(): List<ProjectGraph> {
var generalCounter = 0
var oldLayer = 0
val nodes = mutableListOf<ProjectGraph>()
Expand Down
13 changes: 13 additions & 0 deletions ...t-generator/src/test/kotlin/io/github/cdsap/projectgenerator/ProjectGraphGeneratorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package io.github.cdsap.projectgenerator

import io.github.cdsap.projectgenerator.model.ClassesPerModule
import io.github.cdsap.projectgenerator.model.ClassesPerModuleType
import io.github.cdsap.projectgenerator.model.ProjectGraph
import io.github.cdsap.projectgenerator.model.Shape
import io.github.cdsap.projectgenerator.model.TypeProjectRequested
import org.junit.jupiter.api.Assertions.*
Expand All @@ -11,6 +12,18 @@ import org.junit.jupiter.params.provider.EnumSource

class ProjectGraphGeneratorTest {

@Test
fun `generated graph is consumed as a read-only result`() {
val nodes: List<ProjectGraph> = ProjectGraphGenerator(
numberOfLayers = 1,
distribution = listOf(1),
typeOfProjectRequested = TypeProjectRequested.JVM,
classesPerModule = ClassesPerModule(ClassesPerModuleType.FIXED, 10)
).generate()

assertEquals(listOf("module_0_1", "module_1_2"), nodes.map { it.id })
}

@ParameterizedTest
@EnumSource(Shape::class)
fun `generates every shape at the minimum module count`(shape: Shape) {
Expand Down
Loading