Skip to content

Fix test failures from testing refactor fallout #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zgjim Haziri (ZgjimHaziri) merged 1 commit into from
Jul 1, 2026
Merged

Fix test failures from testing refactor fallout #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/commands/configuration-management/config-validate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { testContext } from "../../utls/test-context";
import { loggingTestTransport } from "../../jest.setup";
import { SchemaValidationResponse } from "../../../src/commands/configuration-management/interfaces/package-validation.interfaces";
import { getJsonFromFile } from "../../utls/fs-utils";
import * as fs from "fs";

describe("Config validate", () => {

Expand Down Expand Up @@ -170,6 +171,8 @@ describe("Config validate", () => {

mockAxiosPost(VALIDATE_URL, response);

const mockWriteFileSync = jest.spyOn(fs, "writeFileSync");

await new PackageValidationService(testContext).validatePackage("my-package", ["DATA_PIPELINES"], null, true);

expect(mockWriteFileSync).toHaveBeenCalledWith(
Expand Down
21 changes: 6 additions & 15 deletions tests/core/utils/file.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,18 @@ describe("FileService", () => {
const symLinkSourceTempDir = path.join(os.tmpdir(), "file-service-symlink-source");

beforeAll(() => {
fileService = new FileService();

if (!fs.existsSync(tempDir)) {
fs.mkdirSync(tempDir, { recursive: true, mode: 0o700 });
}
rmTempDir(tempDir);
rmTempDir(symLinkSourceTempDir);

if (!fs.existsSync(symLinkSourceTempDir)) {
fs.mkdirSync(symLinkSourceTempDir, { recursive: true, mode: 0o700 });
}
fs.mkdirSync(tempDir, { recursive: true, mode: 0o700 });
fs.mkdirSync(symLinkSourceTempDir, { recursive: true, mode: 0o700 });

fileService = new FileService();
});

afterAll(() => {
if (fs.existsSync(tempDir)) {
rmTempDir(tempDir);
}

if (fs.existsSync(symLinkSourceTempDir)) {
rmTempDir(tempDir);
}
rmTempDir(tempDir);
rmTempDir(symLinkSourceTempDir);
});

describe("zipDirectoryInBatchExportFormat", () => {
Expand Down
Loading