Skip to content

Add OSSF Scorecard workflow to gh-workflows module#651

Open
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:add-scorecard
Open

Add OSSF Scorecard workflow to gh-workflows module#651
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:add-scorecard

Conversation

@erikgb

@erikgb erikgb commented Jun 19, 2026

Copy link
Copy Markdown
Member

This adds a slightly modified version of https://github.com/cert-manager/cert-manager/blob/6c9253775a067378b6d237982fab105601611901/.github/workflows/scorecards.yml to the gh-workflows module. This should ensure we get code scanning in all cert-manager projects using makefile-modules.

Compared with the original, I have modified the following:

  • Added a generated note header
  • Removed the cron schedule, as pushes to the default branch probably will happen often enough
  • Extended the push clause with both our variants of default branch name: main and master
  • Changed file extension from .yml to .yaml (this will require a manual upgrade in cert-manager)

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 19, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2026
@erikgb

erikgb commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/cc @inteon

@cert-manager-prow cert-manager-prow Bot requested a review from inteon June 19, 2026 22:42
@erikgb erikgb changed the title Add OSSF Scorecard workflow to repository-base WIP: Add OSSF Scorecard workflow to repository-base Jun 21, 2026
@cert-manager-prow cert-manager-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2026
@cert-manager-prow cert-manager-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2026
@erikgb erikgb changed the title WIP: Add OSSF Scorecard workflow to repository-base Add OSSF Scorecard workflow to repository-base Jun 22, 2026
@cert-manager-prow cert-manager-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2026
@erikgb erikgb changed the title Add OSSF Scorecard workflow to repository-base Add OSSF Scorecard workflow to gh-workflows module Jun 22, 2026
@erikgb

erikgb commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@inteon, this should be ready for review now.

@inteon

inteon commented Jun 24, 2026

Copy link
Copy Markdown
Member

@erikgb are we sure this will not run on private forks?

@erikgb

erikgb commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@erikgb are we sure this will not run on private forks?

That's a good point, but then we have the issue in cert-manager already. I will fix it.

@erikgb

erikgb commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Fixed your remark now, @inteon. PTAL! 🙏

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an OSSF Scorecard GitHub Actions workflow to the gh-workflows module and wires it into the repo so downstream consumers can generate the same workflow into their repositories.

Changes:

  • Introduces a new scorecards.yaml workflow template under modules/gh-workflows/base/ and a generated copy under .github/workflows/.
  • Adds a generate-gh-workflows make target to copy the module’s base workflow files into the repository.
  • Updates Renovate configuration to ignore updates to the generated Scorecards workflow file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
renovate-config.json5 Ignores Renovate updates for the generated Scorecards workflow.
modules/gh-workflows/base/.github/workflows/scorecards.yaml Adds the source-of-truth Scorecards workflow template used by the module.
modules/gh-workflows/01_mod.mk Adds a generator target to copy module base workflows into the repo.
.github/workflows/scorecards.yaml Adds the generated Scorecards workflow in the repository root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

analysis:
name: Scorecards analysis
runs-on: ubuntu-latest
if: github.repository_owner == 'cert-manager' && github.ref_name == github.event.repository.default_branch

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description.

Comment thread modules/gh-workflows/base/.github/workflows/scorecards.yaml Outdated
Comment thread .github/workflows/scorecards.yaml Outdated
Comment thread modules/gh-workflows/01_mod.mk
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb

erikgb commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

/cc @wallrj

I have addressed the comments from Copilot now.

@cert-manager-prow cert-manager-prow Bot requested a review from wallrj July 7, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants