CFE-3882: Added date binary inside cfengine - #2450
Open
victormlg wants to merge 1 commit into
Open
Conversation
victormlg
changed the title
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
Added /var/cfengine/bin/date from coreutils, in a similar way to diff, to be able to parse date and time Signed-off-by: Victor Moene <victor.moene@northern.tech>
nickanderson
approved these changes
Aug 24, 2026
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, though I still wish we didn't have to exec out
craigcomstock
approved these changes
Aug 24, 2026
larsewi
requested changes
Aug 25, 2026
| * POSIX user database and does not ship this header at all. | ||
| * | ||
| * Several coreutils lib source files (idcache.c, userspec.c, ...) | ||
| * unconditionally include <pwd.h>, even though the functionality it |
Contributor
There was a problem hiding this comment.
The proper fix would be to patch the source to not include these unconditionally. If the assertion is wrong, that would surface this during compile time, instead of hiding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.