Skip to content

Updated syntax-description.json and lint tests for new syntax elements - #220

Merged
olehermanse merged 2 commits into
mainfrom
pr-syntax-description-update-with-tests
Aug 26, 2026
Merged

Updated syntax-description.json and lint tests for new syntax elements#220
olehermanse merged 2 commits into
mainfrom
pr-syntax-description-update-with-tests

Conversation

@claude

@claude claude Bot commented Aug 26, 2026

Copy link
Copy Markdown

Requested by Ole Herman · Slack thread

Before: cfengine lint does not know about the newest CFEngine syntax elements: policy using the reactor bundle type is rejected with "Bundle type must be one of (agent, common, edit_line, edit_xml, monitor, server, watch)", calls to the strtotime() function are reported as calls to an unknown function, and the silence attribute for body changes is missing from the bundled syntax description.

After: cfengine lint accepts bundle reactor, strtotime() calls, and the silence attribute in body changes, and the bundle type error message now lists reactor as a valid bundle type. All test suites (unit, format, lint, shell) pass.

The first commit is taken from #219 (#219), with the original authorship preserved.

How: the second commit updates the tests to match - the expected output of the bundle type lint test now includes reactor, and a new lint test exercises the reactor bundle type, the strtotime() function, and the silence attribute.

github-actions Bot and others added 2 commits August 26, 2026 14:34
Updated the expected output of the bundle type lint test to include
the new reactor bundle type, and added a lint test exercising the
reactor bundle type, the strtotime() function, and the silence
attribute in body changes.

Changelog: none
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.33%. Comparing base (59c539f) to head (ea2f86f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   52.33%   52.33%           
=======================================
  Files          32       32           
  Lines        4108     4108           
=======================================
  Hits         2150     2150           
  Misses       1958     1958           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olehermanse
olehermanse merged commit 7ed3fe3 into main Aug 26, 2026
13 checks passed
@olehermanse
olehermanse deleted the pr-syntax-description-update-with-tests branch August 26, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants