Prove workflow-to-CHASM backfill cursor replay - #42
Open
chaptersix wants to merge 1 commit into
Open
chaptersix wants to merge 1 commit into
chaptersix wants to merge 1 commit into
Conversation
This was referenced Sep 5, 2026
chaptersix
marked this pull request as ready for review
September 5, 2026 01:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workflow-backed schedulers store each ongoing backfill's
StartTimeas an exclusive cursor. The CHASM migration converter currently clears the correspondingLastProcessedTime, so CHASM treats the transferred range as fresh and generates the already-processed boundary again.Violated invariant
Migration must preserve the remaining occurrence set
(exclusive cursor, inclusive end]. Every occurrence already accounted for by V1 must remain excluded, while every later occurrence must remain actionable.Minimal reproduction
The deterministic test uses a one-minute schedule, cursor
2026-08-01T11:59:00Z, and end12:00:00Z:12:00.11:59and12:00.Ordinary CI runs the native control and skips the known counterexample. Expose it with:
Evidence
The production trace is
convertBackfillsLegacyToCHASM→BackfillerTaskHandler.processBackfill: the converter clears progress, then the backfiller subtracts one millisecond for a fresh inclusive range.Scope
This layer contains evidence only; it intentionally makes no production change. The opposite CHASM-to-workflow fresh-range boundary is covered by upstream PR temporalio#11878 and is not duplicated here.
Validation
Stack
mainmigration-backfill/preserve-cursor)Rendered failure and sequence artifacts are attached below.