feat: make bridge network mode default - #9
Conversation
9ae4521 to
ab445f8
Compare
| - "465:465" | ||
| - "587:587" | ||
| - "993:993" | ||
| - "3340:3340" |
There was a problem hiding this comment.
@j4n looks like you aren't exposing the turn port
you want something like this:
turn_port = 3478
turn_min_port = 49152
turn_max_port = 65535
then in compose.yaml
- "3478:3478/udp"
- "49152-65535:49152-65535/udp"
reason: turn will start to enumerate ports so it's best practice allow large udp ranges for this.
There was a problem hiding this comment.
@j4n also it's best practice if you're going to use bridge-mode explicitly define the bridge
networks:
default:
enable_ipv6: true
this network can be whatever you want namespace wise ie chatmail. consider adding the enable_ipv6: bool given that there's a lot of focus on ipv6 from experience.
|
|
||
| services: | ||
| chatmail: | ||
| network_mode: "host" |
There was a problem hiding this comment.
@j4n after some thought from our chats, my research, and things i've ran into. i think it's likely a better approach to just use network_mode: host for a singular compose stack vs giving user options of bridging.
reason: bridging can get complex really fast with something like chatmail. plus without manipulating the daemon you theoretically lose the client-ip.
Map the necessary ports; this means loosing client IP visibility in the container but maybe thats a good thing for privacy?