fix: readd generated code - #80
Merged
Merged
Conversation
In chatmail#78 the `#[test]` generation has been removed, this left the folders `yerpc/tests/{qt,typescript}` stale. This PR uses [insta](https://docs.rs/insta/latest/insta/index.html) to test the generated code. When using insta, a test run will make sure the snapshots are always in sync (as opposed to the former approach, where updates were silently overwritten)
link2xt
approved these changes
Sep 3, 2026
| Ok(()) | ||
| } | ||
|
|
||
| use std::path::Path; |
Contributor
There was a problem hiding this comment.
All imports are usually at the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #78 the
#[test]generation has been removed, this left the foldersyerpc/tests/{qt,typescript}stale. Note: the commited generated qt bindings have been out of sync with the actual implementation and are updated in this pr, that's why the diff foryerpc/tests/snapshots/axum__tests__qt__client_hpp.snapis larger.This PR uses insta to test the generated code. When using insta, a test run will make sure the snapshots are always in sync (as opposed to the former approach, where updates were silently overwritten)