Skip to content

feature/INT-1659 - Accept header + schema 3.0 initial development#624

Open
david-ruiz-cko wants to merge 2 commits into
masterfrom
feature/INT-1659
Open

feature/INT-1659 - Accept header + schema 3.0 initial development#624
david-ruiz-cko wants to merge 2 commits into
masterfrom
feature/INT-1659

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This pull request introduces several enhancements and extensions to the Accounts API client, focusing on improved schema versioning support, expanded entity management, and broader business type and role coverage. The changes add flexible API methods to specify schema versions, introduce new model fields and types, and extend enums to support a wider range of business and company scenarios.

API client enhancements for schema versioning:

  • Added overloaded methods to ApiClient and AccountsClient (both async and sync) to accept custom headers, specifically to support specifying a schemaVersion for requests. Default schema version is set to "3.0" if not provided. (src/main/java/com/checkout/ApiClient.java, src/main/java/com/checkout/ApiClientImpl.java, src/main/java/com/checkout/accounts/AccountsClient.java, src/main/java/com/checkout/accounts/AccountsClientImpl.java) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

Model and enum extensions:

  • Added new model classes and fields to support additional business requirements:

    • Introduced AgreedTerms model for capturing agreement metadata. (src/main/java/com/checkout/accounts/AgreedTerms.java)
    • Added additionalTradingNames and isRegisteredCompany fields to Company. (src/main/java/com/checkout/accounts/Company.java)
    • Added day field to DateOfIncorporation. (src/main/java/com/checkout/accounts/DateOfIncorporation.java)
    • Introduced new enum CompanyPosition for more granular company role identification. (src/main/java/com/checkout/accounts/CompanyPosition.java)
  • Expanded supported business types and entity roles:

    • Extended BusinessType enum with many new types (e.g., INDIVIDUAL_OR_SOLE_PROPRIETORSHIP, NON_PROFIT_ENTITY, etc.). (src/main/java/com/checkout/accounts/BusinessType.java)
    • Extended EntityRoles enum with new roles (DIRECTOR, CONTROL_PERSON). (src/main/java/com/checkout/accounts/EntityRoles.java)

These changes provide greater flexibility for clients to interact with the API using different schema versions, and ensure the models and enums better reflect the diverse range of business entities and roles that may be encountered.

@david-ruiz-cko
david-ruiz-cko requested a review from a team July 24, 2026 10:59
@agent-wall-e

agent-wall-e Bot commented Jul 24, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:374>200

Operational gates

  • ✅ jira_ticket (INT-1659)
  • ✅ independent_review

Files analysed: 22


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 24, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope374>200 classifying §2.1 M8 More than 200 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Jul 24, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:389>200

Operational gates

  • ✅ jira_ticket (INT-1659)
  • ✅ independent_review

Files analysed: 22


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 24, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope389>200 classifying §2.1 M8 More than 200 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@david-ruiz-cko david-ruiz-cko changed the title feature/INT-1659 - Accept header mandatory + schema 3.0 initial development feature/INT-1659 - Accept header + schema 3.0 initial development Jul 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant