Run the tests in GitHub Actions and drop .travis.yml - #44
Open
tas50 wants to merge 2 commits into
Open
Conversation
Travis stopped serving open source projects in 2021, so the config here has not run since and the OTP releases it names are long out of support. It is deleted rather than ported: there is nothing worth carrying over. Replaced with a GitHub Actions workflow compiling and running eunit on OTP 26, 27 and 28 -- 26 being what chef-server currently pins, with 27 and 28 covered so regressions surface before that pin moves. The suite needed no changes: 33 tests pass on all three, verified in containers from a clean _build. Dialyzer is clean, so it gates. .gitignore gains _build/ where it was missing; the existing entries predate rebar3, so a build leaves the tree dirty. Signed-off-by: Tim Smith <tim@mondoo.com>
I had this gating on the strength of a dialyzer run that reused a _build left populated by the test profile, which put eunit and envy in the PLT and hid 3 warnings. On a clean checkout -- which is what CI does -- they are reported, so the job as written would have failed on arrival. The warnings are unresolved external functions rather than defects in this code, so continue-on-error is right for now; it should come off once they are resolved. Signed-off-by: Tim Smith <tim@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis stopped serving open source projects in 2021, so
.travis.ymlhere has not run since and the OTP releases it names are long out of support. Deleted rather than ported — there is nothing worth carrying over.Replaced with a GitHub Actions workflow compiling and running eunit on OTP 26, 27 and 28 — 26 being what chef-server currently pins, with 27 and 28 covered so regressions surface before that pin moves.
The suite needed no changes
33 tests pass on all three versions, verified in
erlang:26,erlang:27anderlang:28containers from a clean_build. Worth stating plainly: across the chef-owned Erlang dependencies I surveyed, several no longer build or have failing suites, so being green as-is is not a given here.Dialyzer
Dialyzer is clean, so it gates.
Also
.gitignoregains_build/where it was missing — the existing entries predate rebar3, so a build currently leaves the tree dirty.