feat(security): migrate API keys to SecretStorage#257
Merged
Conversation
b9ca41d to
fcf81b1
Compare
a5472f5 to
f299477
Compare
Deploying podnotes with
|
| Latest commit: |
d7deb9d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a112463.podnotes.pages.dev |
| Branch Preview URL: | https://feat-secret-storage.podnotes.pages.dev |
f299477 to
d7deb9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move PodNotes' OpenAI and Deepgram API keys out of plugin
data.jsonand normal settings exports into Obsidian SecretStorage.This change also raises the pending release's minimum Obsidian version to 1.11.5. Obsidian 1.11.4 introduced the SecretStorage API, but 1.11.5 added operating-system-backed encryption on disk. Published compatibility history remains unchanged, so the release planner will map only 2.19.0 to the new floor.
Migration and security boundary
data.jsonunchanged and retryable.data.json.SecretStorage is vault-local shared infrastructure, not plugin isolation. Other installed plugins can access the same secret collection. Moving a key cannot erase copies in backups, Obsidian Sync history, snapshots, or old plaintext exports, so the documentation includes rotation and cleanup guidance.
Settings, import, and lifecycle behavior
SecretComponentfor selecting or creating secrets.secretspayload and aborts if a configured value is unavailable locally.Compatibility and release proof
manifest.minAppVersion: 1.11.5versions.jsonentry:2.18.4 -> 0.15.9, unchanged2.19.0 -> 1.11.5package.json,package-lock.json,manifest.json, andversions.jsonVerification
npm run lintnpm run format:checknpm run typechecknpm run build- 436.89 kB, gzip 129.60 kBnpm run test- 76 files, 1,055 testsdocs/requirements.txtThe two updated settings screenshots in
docs/docs/resources/were captured from the isolated Obsidian runtime.