fix: default devnet log filter to info,ckb-script=debug#471
Merged
Conversation
A healthy devnet emits almost no warn-level logs, so with the previous default filter (warn,ckb-script=debug) the `offckb status` Logs panel stayed permanently empty and looked broken. Switch the devnet ckb.toml and ckb-miner.toml templates (and the config editor's embedded reference templates) to info,ckb-script=debug so the per-block log stream is visible while script debug output is preserved. Existing chains keep their current filter; edit [logger] filter in the devnet ckb.toml to opt in. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe devnet logger filter default changes from ChangesDevnet logger defaults
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live-testing
offckb statuson a fresh devnet (see #468 follow-up) showed the Logs panel permanently empty with the default config. The devnet template shipsfilter = "warn,ckb-script=debug", and a healthy devnet produces almost nowarn-level output — so the panel looks broken even though the whole Terminal-module pipeline works.What
ckb/devnet/ckb.toml,ckb/devnet/ckb-miner.toml:[logger] filter→info,ckb-script=debugsrc/tui/devnet-reference-templates.ts: same change in both embedded reference templates used by the config editorREADME.md: update the default-log-level exampleinforestores the per-block log stream in the Logs panel; keepingckb-script=debugpreserves script execution debug output for contract developers.Existing chains are intentionally not migrated (their filter may be user-customized) — the changeset notes how to opt in.
Verification
info,ckb-script=debugmakes the ckb-tui Logs panel stream per-block entries with working level counters